Hi to all, the commit http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=144c7f4e4e023f7a701a1e58524409628295343b for bug 9239 insert a regression on the search of items in print labels. In fact it an error only in one line, line 100. The patch is: - $ccl_query .= "acqdate,st-date-normalized,le=" . $datefrom->output("iso"); + $ccl_query .= "acqdate,st-date-normalized,le=" . $dateto->output("iso");
Created attachment 22842 [details] [review] Fix for bug 11222
Test plan: 1)Start with an installation with bibliografic data and items information. 2)Check that in items there are values inside Accession Date Without the patch: a)Go in Home› Tools› Labels and click on 'New batch' b)Click on 'Add Item(s)' c)Try to select items with option "Added on or before date" d)You will receive an error With the patch: Redone points a),b), c) Now you don't receive an error and you can select items
This bug is on 3.12, 3.14, master
> c)Try to select items with option "Added on or before date" > d)You will receive an error I cannot reproduce this error. Nor can I get any results for any date-based search, whether it be the "before" option, the "after," or both.
So in you install the two optinons not work ? Do you have date inside 'Acquisition date field' in the iterm section. ? In MARC21 is the field 952$d The search is based on Zebra index acqdate
My items do have accession date information, and search results can be correctly sorted by accession date, if that is any indication of the index working.
I'm sorry for my bad english, but i don't understand the situation. Is not present the bug in your installation ? All work without problem ? And your test version is ? Thank you
I do not see the bug in master. I do not get errors when searching by date. However, I also get no results when searching by date.
Last option: do you use QueryParser ? Because with QueryParser on the bug is not present. See from master, labels/label-item-search.pl: 94 $dateto = C4::Dates->new($dateto); 95 if ($QParser) { 96 $ccl_query .= ' && ' if ( $ccl_textbox || $datefrom ); 97 $ccl_query .= "acqdate(-" . $dateto->output("iso") . ')'; 98 } else { 99 $ccl_query .= ' and ' if ( $ccl_textbox || $datefrom ); 100 $ccl_query .= "acqdate,st-date-normalized,le=" . $datefrom->output("iso"); 101 } In fact line 97 [QueryParser on] is OK. Line 100 [QueryParser off] has the bug
Created attachment 22959 [details] [review] [SIGNED-OFF] Bug 11222 - A regression on label-item-search.pl done by Bug 9239 Searching for items to add to a label batch fails with an error if QueryParser is enabled and you use the "Added on or before date" search option. Test plan: 0) Set "UseQueryParser" to "do not try" 1) Start with an installation with bibliografic data and items information. 2) Check that in items there are values inside Accession Date Without the patch: a) Go in Home› Tools› Labels and click on 'New batch' b) Click on 'Add Item(s)' c) Try to select items with option "Added on or before date" d) You will receive an error With the patch: Redone points a),b), c) Now you don't receive an error and you can select items Signed-off-by: Owen Leonard <oleonard@myacpl.org> Added a description of the problem and copied the test plan from the bug report, with the addition of the information that QueryParser must be off to confirm and test.
Created attachment 23091 [details] [review] Bug 11222 - A regression on label-item-search.pl done by Bug 9239
*** Bug 10867 has been marked as a duplicate of this bug. ***
Pushed to master. Thanks, Zeno! Unrelated to this patch, it appears that date accessioned searching from this form isn't working at all if QueryParser is on.
I wrote up the issue with acquisition date searching when QueryParser is enabled in bug 11293.
This patch has been pushed to 3.14.x, will be in 3.14.1
This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Zeno!