The first indicator for MARC21 fields 76x-78x should control whether the entire field displays, not whether the $n subfield displays. To reproduce: view a record that includes a 785 field with indicator 1 set to '1' and the system preference OPACXSLTDetailsDisplay enabled. The 785 field will show up, but according to the standard no display should be generated when 785 indicator 1 is set to '1'. In the MARC21slim2intranetDetail.xsl, MARC21 field 785 are always displayed when present, and indicator 1 is used to determine whether or not to display and 785$n. This was fixed in the opac with bug id 4370.
Still valid.
Created attachment 110517 [details] [review] Bug 11223: Fix the ind1 semantics for 785 in the staff interface For 780 and 785 the field should not display when the first indicator is 1. After checking the code, I found that 785 in staff was missing. This patches fixes that one. To test: - Catalog a record with 785 and 780 fields with one 1st indicator set to 0 and another to 1. - Verify in staff and OPAC detail pages that only the fields with 0 display.
Created attachment 110525 [details] [review] Bug 11223: Fix the ind1 semantics for 785 in the staff interface For 780 and 785 the field should not display when the first indicator is 1. After checking the code, I found that 785 in staff was missing. This patches fixes that one. To test: - Catalog a record with 785 and 780 fields with one 1st indicator set to 0 and another to 1. - Verify in staff and OPAC detail pages that only the fields with 0 display. Signed-off-by: David Nind <david@davidnind.com>
Thx, David!
Created attachment 110743 [details] [review] Bug 11223: Fix the ind1 semantics for 785 in the staff interface For 780 and 785 the field should not display when the first indicator is 1. After checking the code, I found that 785 in staff was missing. This patches fixes that one. To test: - Catalog a record with 785 and 780 fields with one 1st indicator set to 0 and another to 1. - Verify in staff and OPAC detail pages that only the fields with 0 display. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Another sane and sensible XSLT fix, thanks Katrin Passing QA
Pushed to master for 20.11, thanks to everybody involved!
missing 20.05.x dependencies, no backport
Hm, maybe instead of checking ind1=0 it would be safer to check ind1!=1, so people that don't catalog the indicators are on the safe side. Need to verify still.