Only staff with 'parameters' (administration module) permission can add new frequencies and numbering patterns. This makes it necessary to give serials librarians full permissions to the administration module. Serials permissions should be handled separately. Also, the links to manage frequencies and numbering patterns still show, when you don't have the appropriate permissions.
Created attachment 22878 [details] [review] Bug 11226: subscription frequencies and numbering patterns should be editable with serials permissions Bug 7688 does now allow patrons with serials permissions to edit subscription frequencies/numbering patterns.
Jonathan, your patch includes changes to the .po file, I don't think that is intentional is it? Other than that, it works fine. Happy to sign off when the .po changes are taken out.
Checking in on this - it's still an issue for some of our libraries
Created attachment 29578 [details] [review] Bug 11226: subscription frequencies and numbering patterns should be editable with serials permissions Bug 7688 does now allow patrons with serials permissions to edit subscription frequencies/numbering patterns. Test plan: Try to access to serials/subscription-frequencies.pl and serials/subscription-numberpatterns.pl with the "serials" permissions.
Sorry, I completely forgot this patch. I resubmitted without the po changes.
Created attachment 29612 [details] [review] [SIGNED-OFF] Bug 11226: subscription frequencies and numbering patterns should be editable with serials permissions Bug 7688 does now allow patrons with serials permissions to edit subscription frequencies/numbering patterns. Test plan: Try to access to serials/subscription-frequencies.pl and serials/subscription-numberpatterns.pl with the "serials" permissions. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> With patch and only serial permissions can now access frequences and patterns. No koha-qa errors
Created attachment 29625 [details] [review] [PASSED QA] Bug 11226: subscription frequencies and numbering patterns should be editable with serials permissions Bug 7688 does now allow patrons with serials permissions to edit subscription frequencies/numbering patterns. Test plan: Try to access to serials/subscription-frequencies.pl and serials/subscription-numberpatterns.pl with the "serials" permissions. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> With patch and only serial permissions can now access frequences and patterns. No koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Jonathan!
Pushed to 3.16.x for inclusion in 3.16.2.
Pushed to 3.14.x, will be in 3.14.09