In pendingreserves.pl and reserveratios.pl there is SQL query returning "notes". The only notes field in the query are from biblio and biblioitems table. I suppose the expected result is the note about the reserve. It is in "reserves.reservenote" M. Saby
the notes don't display on the page(pull reserves) at all, so you are currently asking for data that isn't displayed. Also, when I changed "notes," for "reserves.reservenote", the page didn't display the reserve at all. I'm just a bit confused over why this fix needs to be done now.
Carrying over a comment I made in IRC, the holds to pull report originally took the note field from the bib record. However, that's not necessarily all that useful, and the notes were removed from the template by commit a13c0db. However, that commit did not remove the notes column from the SQL. One reasonable resolution would be to simply remove 'notes' from the SQL query.
Ditto for the hold ratios report; at present I don't see any particular reason why either bib-level or request-level notes need to be displayed in that report.
Created attachment 24325 [details] [review] 11231 notes should be reservenotes notes have been removed as they were not displaying in the first place. 1.apply patch 2.verify that both reports work
Created attachment 25958 [details] [review] Bug 11231 - notes should be reservenotes in pendingreserves.pl and reserveratios.pl notes have been removed as they were not displaying in the first place. 1.apply patch 2.verify that both reports work Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 26412 [details] [review] Bug 11231 - notes should be reservenotes in pendingreserves.pl and reserveratios.pl notes have been removed as they were not displaying in the first place. 1.apply patch 2.verify that both reports work Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Francesca!
Pushed to 3.14.x, will be in 3.14.10
Picked for 3.12.15!