Bug 11231 - notes should be reservenotes in pendingreserves.pl and reserveratios.pl
Summary: notes should be reservenotes in pendingreserves.pl and reserveratios.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Francesca
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-10 19:56 UTC by Mathieu Saby
Modified: 2015-06-04 23:30 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
11231 notes should be reservenotes (2.23 KB, patch)
2014-01-14 23:06 UTC, Francesca
Details | Diff | Splinter Review
Bug 11231 - notes should be reservenotes in pendingreserves.pl and reserveratios.pl (2.33 KB, patch)
2014-03-07 19:33 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11231 - notes should be reservenotes in pendingreserves.pl and reserveratios.pl (2.39 KB, patch)
2014-03-17 16:05 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2013-11-10 19:56:07 UTC
In pendingreserves.pl and reserveratios.pl there is SQL query returning "notes". The only notes field in the query are from biblio and biblioitems table.
I suppose the expected result is the note about the reserve.
It is in "reserves.reservenote"

M. Saby
Comment 1 Francesca 2014-01-14 22:21:10 UTC
the notes don't display on the page(pull reserves) at all, so you are currently asking for data that isn't displayed. Also, when I changed "notes," for "reserves.reservenote", the page didn't display the reserve at all. I'm just a bit confused over why this fix needs to be done now.
Comment 2 Galen Charlton 2014-01-14 22:41:02 UTC
Carrying over a comment I made in IRC, the holds to pull report originally took the note field from the bib record.  However, that's not necessarily all that useful, and the notes were removed from the template by commit a13c0db.  However, that commit did not remove the notes column from the SQL.

One reasonable resolution would be to simply remove 'notes' from the SQL query.
Comment 3 Galen Charlton 2014-01-14 22:41:37 UTC
Ditto for the hold ratios report; at present I don't see any particular reason why either bib-level or request-level notes need to be displayed in that report.
Comment 4 Francesca 2014-01-14 23:06:50 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2014-03-07 19:33:54 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2014-03-17 16:05:00 UTC
Created attachment 26412 [details] [review]
Bug 11231 - notes should be reservenotes in pendingreserves.pl and reserveratios.pl

notes have been removed as they were not displaying in the first place.

1.apply patch
2.verify that both reports work

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 7 Galen Charlton 2014-04-18 23:22:22 UTC
Pushed to master.  Thanks, Francesca!
Comment 8 Fridolin Somers 2014-08-06 12:23:53 UTC
Pushed to 3.14.x, will be in 3.14.10
Comment 9 Kyle M Hall 2014-08-13 18:09:28 UTC
Picked for 3.12.15!