Created attachment 23262 [details] [review]
[PASSED QA] Bug 11249 - Add db indexes on borrowers names

The borrowers search is by default on columns surname, firstname, othernames and cardnumber.
(See C4::Members::_express_member_find).
Addind db indexes will really increase the query speed.

This patch adds bd indexes on surname, firstname, othernames (cardnumber has already an index).
Those indexes must be defined with a size because columns are mediumtext.

Test plan :
Test with mysql client :
mysql> explain select * from borrowers where surname like 'A%';
+----+-------------+-----------+-------+---------------+-------------+---------+------+------+-------------+
| id | select_type | table     | type  | possible_keys | key         | key_len | ref  | rows | Extra       |
+----+-------------+-----------+-------+---------------+-------------+---------+------+------+-------------+
|  1 | SIMPLE      | borrowers | range | surname_idx   | surname_idx | 767     | NULL |  395 | Using where |
+----+-------------+-----------+-------+---------------+-------------+---------+------+------+-------------+
=> key show the index is used

Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, changes from updatedatabase and in kohastructure match.
I think deletedborrowers can be left out, as it's not queried when doing
patron searches. Patron deletes still work as expected.

Pushed to master.  Thanks, Fridolin!

Patch pushed to 3.14.x, will be in 3.14.3.
(creates updatedatabase 3.14.02.001)