Bug 11261 - Sample frequencies and numbering patterns should better be mandatory on install
Summary: Sample frequencies and numbering patterns should better be mandatory on install
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: 3.14
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 11309
  Show dependency treegraph
 
Reported: 2013-11-17 21:09 UTC by Katrin Fischer
Modified: 2015-06-04 23:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11261: Sample frequencies and numbering patterns should better be mandatory on install (8.93 KB, patch)
2013-11-19 14:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11261: Sample frequencies and numbering patterns should better be mandatory on install (9.07 KB, patch)
2013-12-05 21:23 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 11261: Sample numbering patterns should better be mandatory on install (9.04 KB, patch)
2013-12-06 14:48 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11261: Sample frequencies should better be mandatory on install (8.64 KB, patch)
2013-12-06 14:48 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11261: make sample serial numbering patterns mandatory during installation (9.10 KB, patch)
2013-12-11 17:59 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 11261: make sample serial frequencies mandatory during installation (8.69 KB, patch)
2013-12-11 17:59 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 11261: make sample serial numbering patterns mandatory during installation (8.80 KB, patch)
2013-12-13 18:18 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11261: make sample serial frequencies mandatory during installation (8.39 KB, patch)
2013-12-13 18:19 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-11-17 21:09:31 UTC
The serials module will not be fully functional and easily usable without frequencies and numbering patterns. I think it would make sense to move those sample files from optional to mandatory.
Comment 1 Jonathan Druart 2013-11-19 14:22:54 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2013-12-05 21:23:52 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-12-05 21:25:19 UTC
Hi Jonathan, 
the first patch is ok, but you are only moving the numbering patterns - what do you think about also moving the frequencies? (sample_frequencies.txt/.sql)
Comment 4 Jonathan Druart 2013-12-06 14:48:19 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2013-12-06 14:48:29 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2013-12-06 14:48:55 UTC
(In reply to Katrin Fischer from comment #3)
> Hi Jonathan, 
> the first patch is ok, but you are only moving the numbering patterns - what
> do you think about also moving the frequencies? (sample_frequencies.txt/.sql)

Yes of course, second patch does that.
Comment 7 Galen Charlton 2013-12-11 17:59:16 UTC Comment hidden (obsolete)
Comment 8 Galen Charlton 2013-12-11 17:59:30 UTC Comment hidden (obsolete)
Comment 9 Kyle M Hall 2013-12-13 18:18:35 UTC
Created attachment 23534 [details] [review]
Bug 11261: make sample serial numbering patterns mandatory during installation

Test plan:
Verify all sample_numberpatterns.* files have been moved from optional
to mandatory directories.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All sample files for numbering patterns are moved from optional
to mandatory.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Kyle M Hall 2013-12-13 18:19:12 UTC
Created attachment 23535 [details] [review]
Bug 11261: make sample serial frequencies mandatory during installation

Test plan:
Verify all sample_frequencies.* files have been moved from optional
to mandatory directories.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 11 Galen Charlton 2013-12-13 18:36:20 UTC
Pushed to master.  Thanks, Jonathan!
Comment 12 Fridolin Somers 2013-12-24 12:59:36 UTC
Patches pushed to 3.14.x, will be in 3.14.2