Currently the seasons are hardcoded in Serials.pm. i will add the German season names, so seasonal patterns can be used, until bug 11262 is fixed.
Created attachment 22991 [details] [review] Bug 11264: Add German seasons to serials This patch adds the German season names to the serials module. Requirements: You must have a German locale de_* on your system. To test: - Add a new subscription in the serials module - Create a subscription for 1/3 months, seasonal - Begins with and inner counter should both be 0 - Year can be 2013 and second row empty - Pick de* as a locale[1] - Test the prediction pattern - it should tell you German seasons now - Save the subscription - make sure the issues are crated with German seasons as well [1] It seems you have to pick it explicitly - the fallback to the system locale noted on the field didn't work for me.
Created attachment 23007 [details] [review] [SIGNED-OFF] Bug 11264: Add German seasons to serials This patch adds the German season names to the serials module. Requirements: You must have a German locale de_* on your system. To test: - Add a new subscription in the serials module - Create a subscription for 1/3 months, seasonal - Begins with and inner counter should both be 0 - Year can be 2013 and second row empty - Pick de* as a locale[1] - Test the prediction pattern - it should tell you German seasons now - Save the subscription - make sure the issues are crated with German seasons as well [1] It seems you have to pick it explicitly - the fallback to the system locale noted on the field didn't work for me. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors. Installed de_DE.UTF-8 and fr_FR.UTF-8 locales Add new suscription, picked locale manually (de_DE in this case) Prediction pattern shows correct labels (to selected locale) Received issues generated with correct numbering Really don't know at this moment how this could be added to general translation. I'm tempted to add a followup for Spanish
I will try to see with Julian if it is possible to find a normal way to translate these strings. While waiting for a patch, this one can be go into the 3.14 branch. Marked as Passed QA
Created attachment 23022 [details] [review] Bug 11264: Add German seasons to serials This patch adds the German season names to the serials module. Requirements: You must have a German locale de_* on your system. To test: - Add a new subscription in the serials module - Create a subscription for 1/3 months, seasonal - Begins with and inner counter should both be 0 - Year can be 2013 and second row empty - Pick de* as a locale[1] - Test the prediction pattern - it should tell you German seasons now - Save the subscription - make sure the issues are crated with German seasons as well [1] It seems you have to pick it explicitly - the fallback to the system locale noted on the field didn't work for me. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors. Installed de_DE.UTF-8 and fr_FR.UTF-8 locales Add new suscription, picked locale manually (de_DE in this case) Prediction pattern shows correct labels (to selected locale) Received issues generated with correct numbering Really don't know at this moment how this could be added to general translation. I'm tempted to add a followup for Spanish Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Will be fix by bug 11262 *** This bug has been marked as a duplicate of bug 11262 ***