To reproduce: - Run prove -v t/db_dependent/Search.t - There will be warnings about "Use of uninitialized value $code_wanted in string" in MARC::Field.
Created attachment 23008 [details] [review] Bug 11269 - Latest MARC::Record makes visible some wrong usage of field->subfield in C4::Search To test: - Run prove -v t/db_dependent/Search.t - There will be warnings about "Use of uninitialized value $code_wanted in string" in MARC::Field. - Apply the patch. - Those warnings are gone. Regards To+
Created attachment 23009 [details] [review] Bug 11269 - Latest MARC::Record makes visible some wrong usage of field->subfield in C4::Search To test: - Run prove -v t/db_dependent/Search.t - There will be warnings about "Use of uninitialized value $code_wanted in string" in MARC::Field. - Apply the patch. - Those warnings are gone. Regards To+ Signed-off-by: Liz Rea <liz@catalyst.net.nz> Tests now pass
I've pushed this to master and 3.14.x. Thanks, Tomás!
This patch has been pushed to 3.12.x, will be in 3.12.7.
I added bug 11269 and bug 11183 into their respective see also's, because I believe the second patch in 11183 may solve the same thing this patch does, just at a later point in the code. If so, I believe the second patch to 11183 should be obsoleted. Could someone else check that please?
@Galen, The module MARC::Record should also be fixed no ? Test if $code_wanted is not undef in subfield().