Koha is only allowing staff to view the first 20 notices from the checkout screen. When you click the link of any other notice past the 20th one - it does not open, it just pops you back to the top of the page. To re-create Look up patron "with notices" Click on the notices tab Change "Show" to "50" Try clicking on one of the notices at the bottom of the list.
Somehow this was marked enhancement instead of bug.
I would like to suggest that this is a critical bug. We can't access portions of patron information.
(In reply to Jesse Maseto from comment #0) > Koha is only allowing staff to view the first 20 notices from the checkout > screen. When you click the link of any other notice past the 20th one - it > does not open, it just pops you back to the top of the page. > > To re-create > Look up patron "with notices" > Click on the notices tab > Change "Show" to "50" > Try clicking on one of the notices at the bottom of the list. This does not require changing the number of shown notices. You can click on the next page of notices and get the same results.
Is this really 3.12? Or also on master?
Does not appears on master.
Actually, on 3.18, which we just upgraded to, we are seeing the opposite now. The first page of notices works as expected, but when you go to the next page, everything is expanded, and cannot be collapsed! If you change view to more than 20 at a time, the first 20 are normal and the rest are expanded. Very weird! Christopher
(In reply to Christopher Brannon from comment #6) > Actually, on 3.18, which we just upgraded to, we are seeing the opposite > now. The first page of notices works as expected, but when you go to the > next page, everything is expanded, and cannot be collapsed! If you change > view to more than 20 at a time, the first 20 are normal and the rest are > expanded. Very weird! > > Christopher Confirmed on 3.18.x and master.
Created attachment 57226 [details] [review] Bug 11274: Sent Notices Tab Not Working Correctl Test plan 1) have a patron with more then 20 notices sent 2) go to patron profile -> notices -> without patch, the showing/hidding of notices content does work correctly only on first loaded page -> with patch, it should work correctly everywhere - try to use paginator, searching, ordering....
Just a quick try, feel free to comment on this approach...
Only one problem I see with this: If I show all notices (that is, enough notices to have to scroll down to reach the bottom of the list) I see that clicking to expand a notice jumps me to the top of the screen.
Created attachment 57673 [details] [review] Bug 11274: Sent Notices Tab Not Working Correctly Test plan 1) have a patron with more then 20 notices sent 2) go to patron profile -> notices -> without patch, the showing/hidding of notices content does work correctly only on first loaded page -> with patch, it should work correctly everywhere - try to use paginator, searching, ordering....
(In reply to Owen Leonard from comment #10) > Only one problem I see with this: If I show all notices (that is, enough > notices to have to scroll down to reach the bottom of the list) I see that > clicking to expand a notice jumps me to the top of the screen. Thanks for testing, should be fine now
Sorry but I'm still having trouble with this: Expanding the notice works fine after changing pages or searching, but not after sorting. However, it seems very random. Some notices will appear and some won't.
Created attachment 57679 [details] [review] Bug 11274 [Alternate] Sent Notices Tab Not Working Correctly This patch implements the notices toggle event using a different method. Using on() lets us bind the event to a parent element, allowing the event to attach to elements which may not exist on the page yet. Test plan the same as original patch: 1) have a patron with more then 20 notices sent 2) go to patron profile -> notices -> without patch, the showing/hidding of notices content does work correctly only on first loaded page -> with patch, it should work correctly everywhere - try to use paginator, searching, ordering....
Before patch was applied, notices on first page were fine but records on next page were indeed expanded but could be collapsed. The patch did not fix this, however when I applied the patch, all the notices appeared on one page expanded and there was no option to collapse them and no option to see them on multiple pages/go to next page.
Created attachment 57854 [details] [review] Bug 11274 Sent Notices Tab Not Working Correctly This patch implements the notices toggle event using a different method. Using on() lets us bind the event to a parent element, allowing the event to attach to elements which may not exist on the page yet. Test plan the same as original patch: 1) have a patron with more then 20 notices sent 2) go to patron profile -> notices -> without patch, the showing/hidding of notices content does work correctly only on first loaded page -> with patch, it should work correctly everywhere - try to use paginator, searching, ordering.... Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Sorry to not been able to test it sooner, I use the Owen's patch and it worked perfect for me, so I obsoleted mine and signed off the Owen's ;) (In reply to Mika from comment #15) > Before patch was applied, notices on first page were fine but records on > next page were indeed expanded but could be collapsed. The patch did not fix > this, however when I applied the patch, all the notices appeared on one page > expanded and there was no option to collapse them and no option to see them > on multiple pages/go to next page. There were two alternative patches, maybe if you accidentaly apply both, this could happen I imagine...
Created attachment 58114 [details] [review] Bug 11274 Sent Notices Tab Not Working Correctly This patch implements the notices toggle event using a different method. Using on() lets us bind the event to a parent element, allowing the event to attach to elements which may not exist on the page yet. Test plan the same as original patch: 1) have a patron with more then 20 notices sent 2) go to patron profile -> notices -> without patch, the showing/hidding of notices content does work correctly only on first loaded page -> with patch, it should work correctly everywhere - try to use paginator, searching, ordering.... Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master for 17.05, thanks Owen!
This patch has been pushed to 16.11.x, will be in 16.11.01.
Pushed to 3.22.x for 3.22.14
Pushed to 16.05.x, for 16.05.06 release