The "show more" link under a facet list in Bootstrap theme is wrong. It redirects to the advanced search. M. Saby
In the same area, search result limitation on Library facet, doesn't work. It returns all biblio records of the selected library.
Created attachment 23155 [details] [review] Proposed patch Bug 11277 Bootstrap theme facets doesn't work properly Two errors: 1. When selecting 'show more' above a facet, the advanced search page is displayed. 2. When restricting search on a library facet, all the biblio records of this library are returned. The patch fixes the way URL are encoded with TT filter. See that: http://search.cpan.org/~abw/Template-Toolkit-2.25/lib/Template/Manual/Filters.pod#url
After applying this patch I find that the "show more" links work, but the "limit to available" link returns no results, and clicking any facet returns no results. I'm continuing to test.
(In reply to Owen Leonard from comment #3) > After applying this patch I find that the "show more" links work, but > the "limit to available" link returns no results, and clicking any > facet returns no results. I'm continuing to test. Thanks for testing. I confirm that for me on an UNIMAC-DB, this patch solves the two bugs: (1) 'show more' facets, and (2) library limitation facet--without breaking neither other facets selection, nor availability restriction. Do you confirm the two bugs before applying the patch? Is it solved with the patch? And other facet selection were working?
I can confirm the bug and the patch seems to fix it nicely for me - testd on a MARC21 database on current master with German data. I made sure to try some facets with umlauts as well. Owen, I am adding my sign-off here, but would feel better if you could take another look?
Created attachment 23495 [details] [review] [SIGNED OFF] Bug 11277 Bootstrap theme facets doesn't work properly Two errors: 1. When selecting 'show more' above a facet, the advanced search page is displayed. 2. When restricting search on a library facet, all the biblio records of this library are returned. The patch fixes the way URL are encoded with TT filter. See that: http://search.cpan.org/~abw/Template-Toolkit-2.25/lib/Template/Manual/Filters.pod#url Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch works nicely. Tests done: - 'More' link on facets redirects to advanced search before applying the patch. After appyling the link works correctly. - In my tests, the facet links themselves worked nicely, limiting the search as expected. - Availability search works ok for me with patch applied. - Also made sure to click on some links containing diacricits (German umlauts).
Created attachment 23496 [details] [review] Bug 11277 Bootstrap theme facets doesn't work properly Two errors: 1. When selecting 'show more' above a facet, the advanced search page is displayed. 2. When restricting search on a library facet, all the biblio records of this library are returned. The patch fixes the way URL are encoded with TT filter. See that: http://search.cpan.org/~abw/Template-Toolkit-2.25/lib/Template/Manual/Filters.pod#url Signed-off-by: Liz Rea <liz@catalyst.net.nz> Current status: Signed Off
Created attachment 23558 [details] [review] [PASSED QA] Bug 11277 Bootstrap theme facets doesn't work properly Two errors: 1. When selecting 'show more' above a facet, the advanced search page is displayed. 2. When restricting search on a library facet, all the biblio records of this library are returned. The patch fixes the way URL are encoded with TT filter. See that: http://search.cpan.org/~abw/Template-Toolkit-2.25/lib/Template/Manual/Filters.pod#url Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch works nicely. Tests done: - 'More' link on facets redirects to advanced search before applying the patch. After appyling the link works correctly. - In my tests, the facet links themselves worked nicely, limiting the search as expected. - Availability search works ok for me with patch applied. - Also made sure to click on some links containing diacricits (German umlauts).
The more links being broken is quite an annyoing bug - upping severity a bit. Liz signed off, so taking the liberty to change my sign off into a QA review :)
Pushed to master. Thanks, Frédéric!
Patches pushed to 3.14.x, will be in 3.14.3