Bug 11280 - Change Withdrawn toggle to drop down selection of authorized values
Summary: Change Withdrawn toggle to drop down selection of authorized values
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 20341
  Show dependency treegraph
 
Reported: 2013-11-21 20:05 UTC by Mickey Coalwell
Modified: 2018-03-06 11:21 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11280 - Change Withdrawn toggle to drop down selection of authorized values (6.17 KB, patch)
2015-12-07 19:52 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11280 - Change Withdrawn toggle to drop down selection of authorized values (6.18 KB, patch)
2015-12-28 22:53 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 11280 - Change Withdrawn toggle to drop down selection of authorized values (6.29 KB, patch)
2016-01-19 09:54 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mickey Coalwell 2013-11-21 20:05:21 UTC
In Item view moredetail.pl, one is given the choice of selecting authorized values for Lost and Damaged statuses through a drop down. However, Withdrawn is a toggle, even though Withdrawn can be assigned various values in the same way as Lost and Damaged. I am proposing that the Withdrawn status have the same selection menu and "set status" formulation as Lost and Damaged. 

Statuses ( Lost )

    Current location:
    Checkout status:  
    Current renewals:  
    Lost status:
    Damaged status:
    Withdrawn?:No
Comment 1 Katrin Fischer 2015-01-06 22:06:04 UTC
Still valid.
Comment 2 Emma Perks 2015-11-26 10:39:01 UTC
Still valid. Requested by library staff
Comment 3 Owen Leonard 2015-12-07 19:52:53 UTC Comment hidden (obsolete)
Comment 4 Aleisha Amohia 2015-12-28 22:53:05 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2015-12-30 11:33:39 UTC
The patch works as expected, but I am wondering if you should not take into account the values which could not exist in the AV.
This could cause data lost.
Comment 6 Katrin Fischer 2016-01-19 09:44:05 UTC
Hi Jonathan, can you give an example? Not sure I understand.
Comment 7 Jonathan Druart 2016-01-19 09:54:31 UTC
Created attachment 46854 [details] [review]
Bug 11280 - Change Withdrawn toggle to drop down selection of authorized values

'Withdrawn' is an authorised value just like 'Lost' and 'Damaged,' so
the item detail screen should offer the same means of selecting one of
multiple values.

This patch re-uses the same template markup and code 'Lost' and 'Damage'
use to make it possible to select a specific withdrawn value.

To test you should have multiple values entered for the authorised value
category 'WITHDRAWN'.

1. Apply the patch and locate any record in the catalog.
2. From the detail screen, click the barcode in the items table to go to
   the item detail page.
3. Confirm that there is a dropdown list of choices for 'Withdrawn
   status.'
4. Try both setting and unsetting various withdrawn statuses.
5. Confirm that setting Lost or Damaged statuses.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Jonathan Druart 2016-01-19 09:55:14 UTC
(In reply to Katrin Fischer from comment #6)
> Hi Jonathan, can you give an example? Not sure I understand.

Sorry, forget that, it did not make sense.
Comment 9 Brendan Gallagher 2016-01-27 06:30:16 UTC
Pushed to Master - Should be in the May 2016 release. Thanks!