Bug 11283 - Restriction type is not translatable
Summary: Restriction type is not translatable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: 3.14
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on: 2720
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-21 22:28 UTC by Katrin Fischer
Modified: 2015-06-04 23:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11283 - Restriction type is not translatable (1.96 KB, patch)
2013-11-22 13:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11283 - Restriction type is not translatable (2.16 KB, patch)
2013-11-24 20:18 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 11283 - Restriction type is not translatable (2.21 KB, patch)
2013-11-27 15:12 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-11-21 22:28:19 UTC
The new restrictions system has different types:
MANUAL, OVERDUES and FINES. 

Those are shown in the interface and seem to come directly from the database, so they are not translatable.

As they are hardcoded translations should be possible and be handled in the template.
Comment 1 Kyle M Hall 2013-11-22 13:56:13 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2013-11-24 20:18:16 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-11-27 15:12:53 UTC
Created attachment 23189 [details] [review]
Bug 11283 - Restriction type is not translatable

The new restrictions system has different types:
MANUAL, OVERDUES and SUSPENSION.

Those are shown in the interface and seem to come directly from the
database, so they are not translatable.

As they are hardcoded translations should be possible and be handled in
the template.

Test Plan:
1) Create a patron with one of each type of restriction
2) Apply this patch
3) Note you see the type with only the first letter capitialized,
   this indicates you are seeing the translatable string

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script. Strings now appear in
updated po files:
  msgid "%s %s Manual %s Overdues %s Suspension %s "

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Galen Charlton 2013-11-27 16:48:22 UTC
Pushed to master.  Thanks, Kyle!
Comment 5 Fridolin Somers 2013-12-13 13:28:57 UTC
This patch has been pushed to 3.14.x, will be in 3.14.1