Bug 11286 - Bug 10602 prevents to create new subfields in authorities
Summary: Bug 10602 prevents to create new subfields in authorities
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 10602
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-22 09:29 UTC by Sophie MEYNIEUX
Modified: 2015-06-04 23:24 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11286: FIX Add a new subfield to an authority frameworks (2.05 KB, patch)
2013-11-22 09:47 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11286: FIX Add a new subfield to an authority frameworks (2.31 KB, patch)
2013-11-24 21:29 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 11286: FIX Add a new subfield to an authority frameworks (2.46 KB, patch)
2013-11-24 22:21 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sophie MEYNIEUX 2013-11-22 09:29:28 UTC
Default value for authorities, added by Bug 10602, was forgotten in insert query, preventing to add new subfields in authorities
Comment 1 Jonathan Druart 2013-11-22 09:47:46 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-11-24 21:29:25 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-11-24 22:21:15 UTC
Created attachment 23123 [details] [review]
[PASSED QA] Bug 11286: FIX Add a new subfield to an authority frameworks

Bug 10602 introduces a bug when adding a new subfield to an authority
framework. A new parameter is added in a sql query but the placeholder
is missing.

Test plan:
- edit an authority framework
- add a new subfield
- save
- boom!
DBD::mysql::st execute failed: called with 16 bind variables when 15 are
needed at
/home/home/src/admin/auth_subfields_structure.pl line 454.
- apply the patch and try again

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described. No koha-qa errors

Tested trying to add subfield to 100, 2 for example.
Without patch silently fails (but error is logged)
With patch subfield creation or elimination is fine

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
One line fix for a bad bug. Confirmed the bug on master and
the fix. Passes all tests and QA script.
Comment 4 Galen Charlton 2013-11-27 18:09:05 UTC
Pushed to master.  Thanks, Jonathan!
Comment 5 Fridolin Somers 2013-12-13 14:24:56 UTC
This patch has been pushed to 3.14.x, will be in 3.14.1