Default value for authorities, added by Bug 10602, was forgotten in insert query, preventing to add new subfields in authorities
Created attachment 23077 [details] [review] Bug 11286: FIX Add a new subfield to an authority frameworks Bug 10602 introduces a bug when adding a new subfield to an authority framework. A new parameter is added in a sql query but the placeholder is missing. Test plan: - edit an authority framework - add a new subfield - save - boom! DBD::mysql::st execute failed: called with 16 bind variables when 15 are needed at /home/home/src/admin/auth_subfields_structure.pl line 454. - apply the patch and try again
Created attachment 23121 [details] [review] [SIGNED-OFF] Bug 11286: FIX Add a new subfield to an authority frameworks Bug 10602 introduces a bug when adding a new subfield to an authority framework. A new parameter is added in a sql query but the placeholder is missing. Test plan: - edit an authority framework - add a new subfield - save - boom! DBD::mysql::st execute failed: called with 16 bind variables when 15 are needed at /home/home/src/admin/auth_subfields_structure.pl line 454. - apply the patch and try again Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors Tested trying to add subfield to 100, 2 for example. Without patch silently fails (but error is logged) With patch subfield creation or elimination is fine
Created attachment 23123 [details] [review] [PASSED QA] Bug 11286: FIX Add a new subfield to an authority frameworks Bug 10602 introduces a bug when adding a new subfield to an authority framework. A new parameter is added in a sql query but the placeholder is missing. Test plan: - edit an authority framework - add a new subfield - save - boom! DBD::mysql::st execute failed: called with 16 bind variables when 15 are needed at /home/home/src/admin/auth_subfields_structure.pl line 454. - apply the patch and try again Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors Tested trying to add subfield to 100, 2 for example. Without patch silently fails (but error is logged) With patch subfield creation or elimination is fine Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> One line fix for a bad bug. Confirmed the bug on master and the fix. Passes all tests and QA script.
Pushed to master. Thanks, Jonathan!
This patch has been pushed to 3.14.x, will be in 3.14.1