To reproduce: - Check out an item that is renewable - Renew setting a manual renwal due date, change the time from 23:59 to something else - Renew - Verify that the time is set to 23:59 instead of your chosen time
It seems to be fixed, please reopen if I am wrong.
Sorry, but this still appears to be an issue for me - retested in current master. My renewal date shows as 07/31/2015 10:59, but the renewal is only made to 07/31/2015 23:59. The time is not taken into account.
Created attachment 41356 [details] [review] Bug 11298: Don't force the renew time to 23:59 If you try to renew an item using the "Renewal due date" at the bottom of the checkouts table, the time will be hardcoded to 23:59 no matter what the user has chosen. Test plan: Check an item out to a patron renew the item and specify a due date using the datetime picker plugin at the bottom of the table Confirm the time you have chosen is correctly used.
Hi, I tested it on a sand box and I do not have good results. The commands fails and nothing happens. See video here https://owncloud.ccsr.qc.ca/index.php/s/jxTIuf3cq0cl5j9/download Regards Marjorie
Sorry Marjorie but I don't manage to watch the video, vlc simply displays an image, nothing moves. Could you please describe the problem?
(In reply to Jonathan Druart from comment #5) > Sorry Marjorie but I don't manage to watch the video, vlc simply displays an > image, nothing moves. > Could you please describe the problem? Hi Jonathan, When i choose a renewal due date, it just hang forever, nothing happens. See capture attached. Regards, Marjorie
Created attachment 43254 [details] renewal due date
Could you check the log file? Looks good here.
(In reply to Jonathan Druart from comment #8) > Could you check the log file? > Looks good here. Sorry Jonathan, I tested it again and it do not work. I don't know if you want logs of action_logs or logs of browser? I tested it with Firefox 41.0.1 and Chrome 45 and it's the same, i have an error in console like: Uncaught SynthaxError : Unexpected token circulation.pl:180 Marjorie
(In reply to Marjorie Barry-Vila from comment #9) > (In reply to Jonathan Druart from comment #8) > > Could you check the log file? > > Looks good here. > > Sorry Jonathan, I tested it again and it do not work. > > I don't know if you want logs of action_logs or logs of browser? > > I tested it with Firefox 41.0.1 and Chrome 45 and it's the same, i have an > error in console like: > Uncaught SynthaxError : Unexpected token circulation.pl:180 > > Marjorie I was asking for the Koha log file, on the server. Could you confirm you don't get this error without the patch and that your pref IntranetUserJS is empty?
(In reply to Jonathan Druart from comment #10) > (In reply to Marjorie Barry-Vila from comment #9) > > (In reply to Jonathan Druart from comment #8) > > > Could you check the log file? > > > Looks good here. > > > > Sorry Jonathan, I tested it again and it do not work. > > > > I don't know if you want logs of action_logs or logs of browser? > > > > I tested it with Firefox 41.0.1 and Chrome 45 and it's the same, i have an > > error in console like: > > Uncaught SynthaxError : Unexpected token circulation.pl:180 > > > > Marjorie > > I was asking for the Koha log file, on the server. > Could you confirm you don't get this error without the patch and that your > pref IntranetUserJS is empty? I don't know how see koha log file on the server, action_logs? In my version 3.18.04, when I make a renewal, it works and I have no error in console but hour of date is not considered. Sorry. Maybe someone else can test on a sandbox? The problem may come from me. Regards, Marjorie
Created attachment 43341 [details] [review] Bug 11298: Don't force the renew time to 23:59 If you try to renew an item using the "Renewal due date" at the bottom of the checkouts table, the time will be hardcoded to 23:59 no matter what the user has chosen. Test plan: Check an item out to a patron renew the item and specify a due date using the datetime picker plugin at the bottom of the table Confirm the time you have chosen is correctly used. Followed test plan. It works as advertised. Signed-off-by: Marc Véron <veron@veron.ch>
Note: I tested on current master (3.21.00.034)
Created attachment 43569 [details] [review] [PASSED QA] Bug 11298: Don't force the renew time to 23:59 If you try to renew an item using the "Renewal due date" at the bottom of the checkouts table, the time will be hardcoded to 23:59 no matter what the user has chosen. Test plan: Check an item out to a patron renew the item and specify a due date using the datetime picker plugin at the bottom of the table Confirm the time you have chosen is correctly used. Followed test plan. It works as advertised. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Jonathan!
Pushed to 3.20.x will be in 3.20.5
Pushed to 3.18.x, is in 3.18.12.