Bug 11316 - plugin icon missing tooltip in addbiblio.pl
Summary: plugin icon missing tooltip in addbiblio.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Mark Tompsett
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-27 18:16 UTC by Mark Tompsett
Modified: 2015-06-04 23:23 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 11316 - plugin icon missing tooltip in addbiblio.pl (2.54 KB, patch)
2013-11-27 18:22 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11316 - plugin icon missing tooltip in addbiblio.pl (2.60 KB, patch)
2013-12-31 21:56 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
[PASSED QA] Bug 11316 - plugin icon missing tooltip in addbiblio.pl (2.71 KB, patch)
2014-01-05 22:05 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Tompsett 2013-11-27 18:16:17 UTC
Home
Search the catalog
Type something and click Submit
Click a result entry
Click the Edit button
Scroll down and click the 'Edit Record'
In the various tabs there are "Clone this subfield", "Delete this subfield", "Repeat this Tag", "Delete this Tag" tooltip help popups when you hover over the icons to the right, but for the plug-in icone there is no tooltip.
Looking at the page source, it is an HTML anchor with the text of "Tag editor", but there is no title attribute set to cause the tooltip popup. This will add the tooltip popup with the text "Tag editor".
Comment 1 Mark Tompsett 2013-11-27 18:22:13 UTC Comment hidden (obsolete)
Comment 2 Biblibre Sandboxes 2013-12-31 21:56:17 UTC
Patch tested with a sandbox, by Christopher Brannon <cbrannon@cdalibrary.org>
Comment 3 Biblibre Sandboxes 2013-12-31 21:56:55 UTC Comment hidden (obsolete)
Comment 4 Christopher Brannon 2013-12-31 21:58:26 UTC
Patch works as defined by test plan.

Christopher
Comment 5 Katrin Fischer 2014-01-05 22:05:51 UTC
Created attachment 23911 [details] [review]
[PASSED QA] Bug 11316 - plugin icon missing tooltip in addbiblio.pl

By adding:
    title=\"Tag editor\"
into the HTML generated in addbiblio, a tooltip displaying
'Tag editor' appears when the moust is hovered over the
plugin icon.

Test Plan:
1) Log into Staff client
2) Click the 'Search the catalog' tab
3) Type something which will generate results
4) Click the title of a result
5) Click the 'Edit' button
6) Scroll down and click the 'Edit Record'
7) Look through the various tabs and notice that all the plugin
   icons have no tooltip.
8) Apply the patch
9) Refresh the page
10) All the plugin icons should have the tooltip text of
    'Tag editor'.

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Adds a title attribute. Works as described.
Comment 6 Galen Charlton 2014-01-06 05:50:57 UTC
Pushed to master.  Thanks, Mark!
Comment 7 Fridolin Somers 2014-02-18 08:01:29 UTC
Patch pushed to 3.14.x, will be in 3.14.4.