Bug 11324 - "Delete All Items" fails except on "Normal Tab"
Summary: "Delete All Items" fails except on "Normal Tab"
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: AlexHorsman
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-30 20:46 UTC by Ian Palko
Modified: 2016-12-05 21:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
bug 11324: delete all only works on 'normal' tab (1.31 KB, patch)
2014-01-14 22:40 UTC, AlexHorsman
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Palko 2013-11-30 20:46:17 UTC
"Delete all items" on Edit dropdown menu when viewing a biblio record will only delete records when in the "Normal" tab.

When viewing another tab, clicking this command does nothing.
Comment 1 AlexHorsman 2014-01-14 21:04:40 UTC
we have tested and we can successfully re-create this issue, we will work on a fix now
Comment 2 AlexHorsman 2014-01-14 22:40:52 UTC
Created attachment 24323 [details] [review]
bug 11324: delete all only works on 'normal' tab

test plan
1. find a book with some items
2. in the marc tab click edit and choose delete all
3. notice it doesn't work
4. apply the patch
5. refresh page
6. try delete all again
Comment 3 Owen Leonard 2014-01-15 15:06:25 UTC
If [% countorders %] and [% countdeletedorders %] are coming up empty on MARCdetail.pl and other pages it's because the variable is not being set. If the variable is not being set, assuming those numbers are zero is inaccurate. Since confirm_deletion() is designed to warn users before taking potentially destructive action I think it's important that it get accurate data.

A quick look suggests it's simply necessary to copy the relevant code from detail.pl to the other affected pages.
Comment 4 Aleisha Amohia 2016-01-07 21:04:57 UTC
I could not reproduce this bug in version 3.23. Must have been fixed? Can someone else test if this bug is still valid?
Comment 5 Ian Palko 2016-01-08 16:36:12 UTC
(In reply to Aleisha Amohia from comment #4)
> I could not reproduce this bug in version 3.23. Must have been fixed? Can
> someone else test if this bug is still valid?

I can confirm, the code seems to have been either copied as Owen suggested, or other fixes have fixed this.

Marking as Resolved:Invalid