There are many inconsistencies on field/subfield descriptions on MARC21 bibliographic frameworks. That fact makes very hard to translate frameworks accurately using an automated procedure
I think for consistency it also makes sense to have the descriptions the same on each framework. But also it will be really nice to have the marc frameworks nicely translatable with po files.
Created attachment 23277 [details] check-diff.sh script to check frameworks
Created attachment 23278 [details] [review] Bug 11330 - Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks This patch tries to make MARC21 bibliographic frameworks internally consistent. It modifies field/subfield descriptions of simple_bib and fastadd frameworks to match corresponding ones of default framework. To test: 1) Download and edit the attached script, check-diff.sh Put on it user, pass and database name of your dev install Copy the script on your git home 2) Run the script (bash check-diff.sh). WARNING: the script removes bibliographic frameworks, and load default, simple_bib and fastadd ones. It will show on screen, and write on file differences.txt, any difference on field/subfield description (liblibrarian) between any framework and default On master it will show a lot of lines 3) Apply the patch 4) Run the script again. Frameworks files must load without problem. There will be no differences NOTE: On fastadd file there are many "space" changes. The reason to that is to format that file to ease the translation process. Not related with this bug, but it reformat the file to match the other ones (default and simple_bib)
Found some changes that need to be done. Switch to In Discussion
Created attachment 23281 [details] [review] Bug 11330 - Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks This patch tries to make MARC21 bibliographic frameworks internally consistent. It modifies field/subfield descriptions of simple_bib and fastadd frameworks to match corresponding ones of default framework. To test: 1) Download and edit the attached script, check-diff.sh Put on it user, pass and database name of your dev install Copy the script on your git home 2) Run the script (bash check-diff.sh). WARNING: the script removes bibliographic frameworks, and load default, simple_bib and fastadd ones. It will show on screen, and write on file differences.txt, any difference on field/subfield description (liblibrarian) between any framework and default On master it will show a lot of lines 3) Apply the patch 4) Run the script again. Frameworks files must load without problem. There will be no differences NOTE: There are many "space" changes. The reason to that is to format files to ease the translation process. Not related with this bug, but necessary. Also a few changes on default framework.
Now it's ready
Created attachment 23321 [details] [review] [SIGNED OFF] Bug 11330 - Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks This patch tries to make MARC21 bibliographic frameworks internally consistent. It modifies field/subfield descriptions of simple_bib and fastadd frameworks to match corresponding ones of default framework. To test: 1) Download and edit the attached script, check-diff.sh Put on it user, pass and database name of your dev install Copy the script on your git home 2) Run the script (bash check-diff.sh). WARNING: the script removes bibliographic frameworks, and load default, simple_bib and fastadd ones. It will show on screen, and write on file differences.txt, any difference on field/subfield description (liblibrarian) between any framework and default On master it will show a lot of lines 3) Apply the patch 4) Run the script again. Frameworks files must load without problem. There will be no differences NOTE: There are many "space" changes. The reason to that is to format files to ease the translation process. Not related with this bug, but necessary. Also a few changes on default framework. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I ran some tests and found one more case where the liblibrarian and libopac columns had slightly different descriptions, adding a follow-up for that.
Created attachment 23322 [details] [review] Bug 11330: Follow-up - Inconsistent field/subfield descriptions on MARC21 bibiographic frameworks Fixes one missing for 951 field description in the Default framework.
Created attachment 24488 [details] [review] Bug 11330 - Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks This patch tries to make MARC21 bibliographic frameworks internally consistent. It modifies field/subfield descriptions of simple_bib and fastadd frameworks to match corresponding ones of default framework. To test: 1) Download and edit the attached script, check-diff.sh Put on it user, pass and database name of your dev install Copy the script on your git home 2) Run the script (bash check-diff.sh). WARNING: the script removes bibliographic frameworks, and load default, simple_bib and fastadd ones. It will show on screen, and write on file differences.txt, any difference on field/subfield description (liblibrarian) between any framework and default On master it will show a lot of lines 3) Apply the patch 4) Run the script again. Frameworks files must load without problem. There will be no differences NOTE: There are many "space" changes. The reason to that is to format files to ease the translation process. Not related with this bug, but necessary. Also a few changes on default framework. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I ran some tests and found one more case where the liblibrarian and libopac columns had slightly different descriptions, adding a follow-up for that. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 24489 [details] [review] Bug 11330: Follow-up - Inconsistent field/subfield descriptions on MARC21 bibiographic frameworks Fixes one missing for 951 field description in the Default framework. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master. Thanks, Bernardo!