The patch for bug 5031 added use of the HTML5 required attributes. The jQuery validator plugin introduced in bug 6209 should also be used, as that will add validation support for non-HTML5 browsers and will standardize the look of messages for validation errors.
Created attachment 23274 [details] [review] Bug 11333: use jQuery validator plugin for CSV profiles forms This patch adds the use of the jQuery validator plugin for the two forms (new and edit) on the CSV profiles page. Doing this standardizes messages that gets displayed on validation errors. This patch, in the process, fixes a bug where if a page has more than one validated form, only the first such form would get the validator plugin applied to it -- it looks like $.validate() does not do implicit iteration. To test: [1] Apply the patch, then go to Tools | CSV profiles. [2] Create a new profile, but leave the name and the MARC/SQL fields blank. When you click the submit button, the form should not be submitted; instead, text will be displayed to the right of each input that lacks required input. [3] As above, but change the profile type and verify that the form is not submitted unless all of the required fields are filled in. [4] Edit an existing form, then empty the MARC/SQL field. Try submitting the form; it should refuse to submit the form and display text saying that the field is required. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 23287 [details] [review] Bug 11333: use jQuery validator plugin for CSV profiles forms This patch adds the use of the jQuery validator plugin for the two forms (new and edit) on the CSV profiles page. Doing this standardizes messages that gets displayed on validation errors. This patch, in the process, fixes a bug where if a page has more than one validated form, only the first such form would get the validator plugin applied to it -- it looks like $.validate() does not do implicit iteration. To test: [1] Apply the patch, then go to Tools | CSV profiles. [2] Create a new profile, but leave the name and the MARC/SQL fields blank. When you click the submit button, the form should not be submitted; instead, text will be displayed to the right of each input that lacks required input. [3] As above, but change the profile type and verify that the form is not submitted unless all of the required fields are filled in. [4] Edit an existing form, then empty the MARC/SQL field. Try submitting the form; it should refuse to submit the form and display text saying that the field is required. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 23326 [details] [review] [PASSED QA] Bug 11333: use jQuery validator plugin for CSV profiles forms This patch adds the use of the jQuery validator plugin for the two forms (new and edit) on the CSV profiles page. Doing this standardizes messages that gets displayed on validation errors. This patch, in the process, fixes a bug where if a page has more than one validated form, only the first such form would get the validator plugin applied to it -- it looks like $.validate() does not do implicit iteration. To test: [1] Apply the patch, then go to Tools | CSV profiles. [2] Create a new profile, but leave the name and the MARC/SQL fields blank. When you click the submit button, the form should not be submitted; instead, text will be displayed to the right of each input that lacks required input. [3] As above, but change the profile type and verify that the form is not submitted unless all of the required fields are filled in. [4] Edit an existing form, then empty the MARC/SQL field. Try submitting the form; it should refuse to submit the form and display text saying that the field is required. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed some tabs, works nicely and as described.
Pushed to master.
This patch has been pushed to 3.14.x, will be in 3.14.1