The current "Library" facet is somewhat ambiguous for Koha installations with multiple libraries. It refers to the holdingbranch, but does not explicitly state this. It would be beneficial to allow the administrator to choose to show facets for the holding library, home library, or both. In addition, the facets should be more explicitly labeled.
Created attachment 23279 [details] [review] Bug 11334 - Add facet for home library The current "Library" facet is somewhat ambiguous for Koha installations with multiple libraries. It refers to the holdingbranch, but does not explicitly state this. It would be beneficial to allow the administrator to choose to show facets for the holding library, home library, or both. In addition, the facets should be more explicitly labeled. Test plan: 1) Apply this patch 2) Check that the facets label "Libraries" now reads "Holding libraries" 3) Update the system preference DisplayLibraryFacets to "home library" 4) Check that the facet now reads "Home libraries" 5) Update the preference again to "both home and holding library" 6) Check that both the facets for home and holding library are now displayed.
Patch tested with a sandbox, by Jen DeMuth <jdemuth@roseville.ca.us>
Created attachment 23323 [details] [review] Bug 11334 - Add facet for home library The current "Library" facet is somewhat ambiguous for Koha installations with multiple libraries. It refers to the holdingbranch, but does not explicitly state this. It would be beneficial to allow the administrator to choose to show facets for the holding library, home library, or both. In addition, the facets should be more explicitly labeled. Test plan: 1) Apply this patch 2) Check that the facets label "Libraries" now reads "Holding libraries" 3) Update the system preference DisplayLibraryFacets to "home library" 4) Check that the facet now reads "Home libraries" 5) Update the preference again to "both home and holding library" 6) Check that both the facets for home and holding library are now displayed. Signed-off-by: Jen DeMuth <jdemuth@roseville.ca.us>
Hi Kyle, found a small bug: + 'DisplayLibraryFacets', 'holdingbranch', 'home|holding|both', 'Defines which library facets to display.', 'Choice' You are setting the default to an invalid value in sysprefs.sql and updatedatabaes. Can you please provide a follow up?
Created attachment 24007 [details] [review] Bug 11334 - Add facet for home library The current "Library" facet is somewhat ambiguous for Koha installations with multiple libraries. It refers to the holdingbranch, but does not explicitly state this. It would be beneficial to allow the administrator to choose to show facets for the holding library, home library, or both. In addition, the facets should be more explicitly labeled. Test plan: 1) Apply this patch 2) Check that the facets label "Libraries" now reads "Holding libraries" 3) Update the system preference DisplayLibraryFacets to "home library" 4) Check that the facet now reads "Home libraries" 5) Update the preference again to "both home and holding library" 6) Check that both the facets for home and holding library are now displayed. Signed-off-by: Jen DeMuth <jdemuth@roseville.ca.us>
Created attachment 24008 [details] [review] Bug 11334 [QA Followup] - Add facet for home library
Setting to passed QA, assuming the bad default system pref value was the only issue. Please update the bug status if I am incorrect!
Hi Kyle, I will take another look and add my sign off lines.
Created attachment 24191 [details] [review] [PASSED QA] Bug 11334 [QA Followup] - Add facet for home library Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 24192 [details] [review] [PASSED QA] Bug 11334 - Add facet for home library The current "Library" facet is somewhat ambiguous for Koha installations with multiple libraries. It refers to the holdingbranch, but does not explicitly state this. It would be beneficial to allow the administrator to choose to show facets for the holding library, home library, or both. In addition, the facets should be more explicitly labeled. Test plan: 1) Apply this patch 2) Check that the facets label "Libraries" now reads "Holding libraries" 3) Update the system preference DisplayLibraryFacets to "home library" 4) Check that the facet now reads "Home libraries" 5) Update the preference again to "both home and holding library" 6) Check that both the facets for home and holding library are now displayed. Signed-off-by: Jen DeMuth <jdemuth@roseville.ca.us> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Changes apply to both prog and bootstrap OPAC and staff client.
Created attachment 24193 [details] [review] [PASSED QA] Bug 11334 [QA Followup] - Add facet for home library Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I am not sure if the change in the label could be confusing to patrons - it might be an idea to still show "Libraries" when only home or holding library are displayed.
Pushed to master. Thanks, Kyle! (In reply to Katrin Fischer from comment #12) > I am not sure if the change in the label could be confusing to patrons - it > might be an idea to still show "Libraries" when only home or holding library > are displayed. I pushed a follow-up that wraps the new facet labels in spans with IDs, making it possible for folks to tweak the labels. A follow-up template change would be easy enough to make if that proves not to be sufficient.