If BorrowersTitles is empty, it causes the library pulldown on the self registration page to be empty, and to have the "Saluation" field have the option "branches".
Created attachment 23318 [details] [review] Bug 11342 - Error with opac self registration if BorrowersTitles is empty If BorrowersTitles is empty, it causes the library pulldown on the self registration page to be empty, and to have the "Saluation" field have the option "branches". This patch also fixes a minor string capitalization issue. Test Plan: 1) Enable OPAC self registration 2) Set the system preference BorrowersTitles to be empty 3) View the self registration page 4) Note the lack of branches in the home library pulldown 5) Apply this patch 6) Note the branches now display in the pulldown
Patch tested with a sandbox, by Christopher Brannon <cbrannon@cdalibrary.org>
Created attachment 23881 [details] [review] Bug 11342 - Error with opac self registration if BorrowersTitles is empty If BorrowersTitles is empty, it causes the library pulldown on the self registration page to be empty, and to have the "Saluation" field have the option "branches". This patch also fixes a minor string capitalization issue. Test Plan: 1) Enable OPAC self registration 2) Set the system preference BorrowersTitles to be empty 3) View the self registration page 4) Note the lack of branches in the home library pulldown 5) Apply this patch 6) Note the branches now display in the pulldown Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Patch works as defined in test plan. Christopher
Created attachment 23910 [details] [review] [PASSED QA] Bug 11342 - Error with opac self registration if BorrowersTitles is empty If BorrowersTitles is empty, it causes the library pulldown on the self registration page to be empty, and to have the "Saluation" field have the option "branches". This patch also fixes a minor string capitalization issue. Test Plan: 1) Enable OPAC self registration 2) Set the system preference BorrowersTitles to be empty 3) View the self registration page 4) Note the lack of branches in the home library pulldown 5) Apply this patch 6) Note the branches now display in the pulldown Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested in bootstrap and prog OPAC, with BorrowersTitle configured and emptied. Passes all tests and QA script. Note: The titles pull down has 2 empty entries in master with and without the patch.
Pushed to master. Thanks, Kyle!
Patch pushed to 3.14.x, will be in 3.14.4.