Bug 11351 - Add support for SIP2 media types
Summary: Add support for SIP2 media types
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-06 18:35 UTC by Kyle M Hall
Modified: 2014-12-07 20:07 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11351 - Add support for SIP2 media types (8.45 KB, patch)
2013-12-06 18:38 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11351 - Add support for SIP2 media types (8.46 KB, patch)
2013-12-06 18:41 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11351 - Add support for SIP2 media types (17.49 KB, patch)
2013-12-06 19:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11351 - Add support for SIP2 media types (19.05 KB, patch)
2013-12-09 13:23 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11351 - Add support for SIP2 media types [v3.12.06] (18.60 KB, patch)
2013-12-09 13:42 UTC, Kyle M Hall
Details | Diff | Splinter Review
Rebased against master 2014-01-31 (19.10 KB, patch)
2014-01-31 13:50 UTC, Benjamin Rokseth
Details | Diff | Splinter Review
Tested according to described plan: - ran updatedatabase.pl - edited itemtype of book and added SIP media type book - restarted SIP server - made SIP request of book - verified that SIP media type returned CK001 (=book) (19.35 KB, patch)
2014-01-31 13:55 UTC, Benjamin Rokseth
Details | Diff | Splinter Review
[PASSED QA] Bug 11351 - Add support for SIP2 media types (19.23 KB, patch)
2014-04-23 08:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 11351 - Add support for SIP2 media types - French file (2.49 KB, patch)
2014-04-23 13:28 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-12-06 18:35:25 UTC
Koha's SIP2 server implementation does not currently support the SIP2 protocol field "media type" ( CK ). It should.
Comment 1 Kyle M Hall 2013-12-06 18:38:36 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2013-12-06 18:41:10 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2013-12-06 19:25:50 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2013-12-09 13:23:46 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2013-12-09 13:42:00 UTC Comment hidden (obsolete)
Comment 6 Petter Goksøyr Åsen 2014-01-29 12:29:05 UTC
I'd like to test this, can you rebase?

Thanks
Comment 7 Benjamin Rokseth 2014-01-31 13:50:34 UTC Comment hidden (obsolete)
Comment 8 Benjamin Rokseth 2014-01-31 13:55:53 UTC Comment hidden (obsolete)
Comment 9 Martin Renvoize 2014-04-23 08:51:20 UTC
Created attachment 27453 [details] [review]
[PASSED QA] Bug 11351 - Add support for SIP2 media types

Koha's SIP2 server implementation does not currently support the SIP2
protocol field "media type" ( CK ).

This patch implements the SIP2 media type by allowing an arbitrary
mapping of itemtypes to SIP2 media types.

Test Plan:
1) Apply this patch
2) Run updatedatabase
3) Edit an itemtype, select a SIP media type, and save the changes
4) Make a SIP2 Item Information Request
5) Verify that the CK field of the Item Information Response contains
   the correct media type code.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize 2014-04-23 08:52:14 UTC
I'm happy this works as advertised, passes all qa tests and is a relatively trivial patch.
Comment 11 Jonathan Druart 2014-04-23 13:28:51 UTC
Created attachment 27476 [details] [review]
Bug 11351 - Add support for SIP2 media types - French file

This patch adds the SIP_MEDIA_TYPE AV for the fr-FR file.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 12 Galen Charlton 2014-04-28 18:25:18 UTC
Pushed to master.  Thanks, Kyle!