Tools > Labels home > Manage label layouts > Create Label layout has two untranslatable pull-downs, a layout type one, and text justification one. The texts for those pull-downs comes from C4/Creators/Lib.pm
Created attachment 27958 [details] [review] Allow translating the label layout and text justification types Bug 11364: Label layout types and text justification types are not translatable To test: 1) cd misc/translator 2) perl translate update xx-YY 3) check that there's no msgids that contain the layout types or text justification types in po/xx-YY-i-staff-t-prog-v-3006000.po 4) apply patch 5) perl translate update xx-YY 6) check po/xx-YY-i-staff-t-prog-v-3006000.po that it contains the msgid for the frequencies. (search for "BLOCK translate_label_types" and "BLOCK translate_justification_types")
Patch is Ok, but think that old legends must be removed, from C4/Creators/Lib.pm around line 129.
Created attachment 36722 [details] [review] [Follow-up] Bug 11364 - Label layout types and text justification types are not translatable Removed obsolete code from from C4/Creators/Lib.pm around line 129.
Created attachment 36788 [details] [review] Bug 11364: Label layout types and text justification types are not translatable To test: 1) cd misc/translator 2) perl translate update xx-YY 3) check that there's no msgids that contain the layout types or text justification types in po/xx-YY-i-staff-t-prog-v-3006000.po 4) apply patch 5) perl translate update xx-YY 6) check po/xx-YY-i-staff-t-prog-v-3006000.po that it contains the msgid for the frequencies. (search for "BLOCK translate_label_types" and "BLOCK translate_justification_types") Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 36789 [details] [review] Bug 11364 - Label layout types and text justification types are not translatable Removed obsolete code from from C4/Creators/Lib.pm around line 129. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment on attachment 36789 [details] [review] Bug 11364 - Label layout types and text justification types are not translatable Review of attachment 36789 [details] [review]: ----------------------------------------------------------------- ::: C4/Creators/Lib.pm @@ -124,4 @@ > {type => 'HBO', name => 'Helvetica-Bold-Oblique', selected => 0}, > ]; > > -my $text_justification_types = [ This variable is still used. However, the name keys could be removed.
Created attachment 36793 [details] [review] Bug 11364: Label layout types and text justification types are not translatable To test: 1) cd misc/translator 2) perl translate update xx-YY 3) check that there's no msgids that contain the layout types or text justification types in po/xx-YY-i-staff-t-prog-v-3006000.po 4) apply patch 5) perl translate update xx-YY 6) check po/xx-YY-i-staff-t-prog-v-3006000.po that it contains the msgid for the frequencies. (search for "BLOCK translate_label_types" and "BLOCK translate_justification_types") Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patch pushed to master. Thanks Pasi!
Pushed to 3.18.x will be in 3.18.5
Pushed to 3.16.x, will be in 3.16.9