Bug 11365 - Label card element title texts cannot be translated
Summary: Label card element title texts cannot be translated
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: paxed
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-10 10:08 UTC by paxed
Modified: 2015-06-04 23:30 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Allow translating the patron card element title texts (4.81 KB, patch)
2014-05-06 09:12 UTC, paxed
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11365: Label card element title texts cannot be translated (4.99 KB, patch)
2014-05-17 00:31 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 11365: Label card element title texts cannot be translated (5.04 KB, patch)
2014-05-21 10:35 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2013-12-10 10:08:57 UTC
Tools > Labels home > Manage label Layouts lists the currently available layouts. The word "Layouts" eg. in the "Currently Available Layouts" -text cannot be translated. This also applies to "Templates", "Profiles" and "Batches" - these texts come from patroncards/manage.pl
Comment 1 paxed 2013-12-10 10:14:13 UTC
This also applies to the table that lists the available Layouts - the table column headers cannot be translated, and those texts come from the same place.
Comment 2 paxed 2014-05-06 09:12:45 UTC Comment hidden (obsolete)
Comment 3 Bernardo Gonzalez Kriegel 2014-05-17 00:31:17 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-05-21 10:35:27 UTC
Created attachment 28397 [details] [review]
Bug 11365: Label card element title texts cannot be translated

To test:

1) cd misc/translator
2) perl translate update xx-YY
3) check that there's no msgid that contains the patron card label
   element title texts in po/xx-YY-i-staff-t-prog-v-3006000.po
4) apply patch
5) perl translate update xx-YY
6) check po/xx-YY-i-staff-t-prog-v-3006000.po that it contains the
   msgid. (search for "BLOCK translate_card_element")

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described. Tested updating po file, translating and installing
language, checked on tools page.
No errors

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Galen Charlton 2014-05-23 14:51:35 UTC
Pushed to master and 3.16.x, along with a follow-up that trims leading and trailing whitespace in the text emitted by the translate_card_element so as to not produce multi-line strings that break the JavaScript alerts.

Thanks, Pasi!