in Acq baskets, there's a pull-down for basket groups. One of the entries in that pull-down is "No group", which is untranslatable.
I can confirm this bug, the string is hardcoded into basket.pl.
I set this as bug minor. I have a patch
Created attachment 25845 [details] [review] Bug 11366 - Acq basket group "No group" untranslatable in Acq baskets, there's a pull-down for basket groups. One of the entries in that pull-down is "No group", which is untranslatable. This string is hard-coded in perl. This patch removes the string from perl to set it has first option in select. To allow it to be default value, the option "Add new group" is moved to last position. Test plan : - Go to a closed aquisition basket in no basket group : cgi-bin/koha/acqui/basket.pl?basketno=x => You see "No group" selected in combobox "Basket group" - Cick on this combobox => You see "No group", then existing basket groups and then "Add new group" - Select a basket group and click on "change basket group" => You see the basket group name in combobox Use translation, for example fr-FR - go to src/misc/translator - run : perl translate update fr-FR => You find in PO file : #: intranet-tmpl/prog/en/modules/acqui/basket.tt:365 #, fuzzy, c-format msgid "No group" msgstr "Nom de groupe" - remove ", fuzzy" and correct translation : "Pas de groupe" - run : perl translate install fr-FR - Go to translated aquisition basket page => You see translated option in combobox
Created attachment 25954 [details] [review] Bug 11366 - Acq basket group "No group" untranslatable in Acq baskets, there's a pull-down for basket groups. One of the entries in that pull-down is "No group", which is untranslatable. This string is hard-coded in perl. This patch removes the string from perl to set it has first option in select. To allow it to be default value, the option "Add new group" is moved to last position. Test plan : - Go to a closed aquisition basket in no basket group : cgi-bin/koha/acqui/basket.pl?basketno=x => You see "No group" selected in combobox "Basket group" - Cick on this combobox => You see "No group", then existing basket groups and then "Add new group" - Select a basket group and click on "change basket group" => You see the basket group name in combobox Use translation, for example fr-FR - go to src/misc/translator - run : perl translate update fr-FR => You find in PO file : #: intranet-tmpl/prog/en/modules/acqui/basket.tt:365 #, fuzzy, c-format msgid "No group" msgstr "Nom de groupe" - remove ", fuzzy" and correct translation : "Pas de groupe" - run : perl translate install fr-FR - Go to translated aquisition basket page => You see translated option in combobox Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 26266 [details] [review] Bug 11366 - Acq basket group "No group" untranslatable in Acq baskets, there's a pull-down for basket groups. One of the entries in that pull-down is "No group", which is untranslatable. This string is hard-coded in perl. This patch removes the string from perl to set it has first option in select. To allow it to be default value, the option "Add new group" is moved to last position. Test plan : - Go to a closed aquisition basket in no basket group : cgi-bin/koha/acqui/basket.pl?basketno=x => You see "No group" selected in combobox "Basket group" - Cick on this combobox => You see "No group", then existing basket groups and then "Add new group" - Select a basket group and click on "change basket group" => You see the basket group name in combobox Use translation, for example fr-FR - go to src/misc/translator - run : perl translate update fr-FR => You find in PO file : #: intranet-tmpl/prog/en/modules/acqui/basket.tt:365 #, fuzzy, c-format msgid "No group" msgstr "Nom de groupe" - remove ", fuzzy" and correct translation : "Pas de groupe" - run : perl translate install fr-FR - Go to translated aquisition basket page => You see translated option in combobox Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master. Thanks, Fridolin!
Pushed to 3.14.x, will be in 3.14.08
Pushed to 3.12.x, will be in 3.12.13