Bug 11366 - Acq basket group "No group" untranslatable
Summary: Acq basket group "No group" untranslatable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-10 10:27 UTC by paxed
Modified: 2015-06-04 23:30 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11366 - Acq basket group "No group" untranslatable (3.35 KB, patch)
2014-03-05 13:48 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 11366 - Acq basket group "No group" untranslatable (3.40 KB, patch)
2014-03-07 19:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11366 - Acq basket group "No group" untranslatable (3.50 KB, patch)
2014-03-13 12:59 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2013-12-10 10:27:37 UTC
in Acq baskets, there's a pull-down for basket groups. One of the entries in that pull-down is "No group", which is untranslatable.
Comment 1 Katrin Fischer 2013-12-29 22:01:36 UTC
I can confirm this bug, the string is hardcoded into basket.pl.
Comment 2 Fridolin Somers 2014-03-05 13:24:36 UTC
I set this as bug minor.
I have a patch
Comment 3 Fridolin Somers 2014-03-05 13:48:41 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2014-03-07 19:01:01 UTC Comment hidden (obsolete)
Comment 5 Marcel de Rooy 2014-03-13 12:59:39 UTC
Created attachment 26266 [details] [review]
Bug 11366 - Acq basket group "No group" untranslatable

in Acq baskets, there's a pull-down for basket groups. One of the entries in that pull-down is "No group", which is untranslatable. This string is hard-coded in perl.

This patch removes the string from perl to set it has first option in select. To allow it to be default value, the option "Add new group" is moved to last position.

Test plan :
- Go to a closed aquisition basket in no basket group : cgi-bin/koha/acqui/basket.pl?basketno=x
=> You see "No group" selected in combobox "Basket group"
- Cick on this combobox
=> You see "No group", then existing basket groups and then "Add new group"
- Select a basket group and click on "change basket group"
=> You see the basket group name in combobox
Use translation, for example fr-FR
- go to src/misc/translator
- run : perl translate update fr-FR
=> You find in PO file :
  #: intranet-tmpl/prog/en/modules/acqui/basket.tt:365
  #, fuzzy, c-format
  msgid "No group"
  msgstr "Nom de groupe"
- remove ", fuzzy" and correct translation : "Pas de groupe"
- run : perl translate install fr-FR
- Go to translated aquisition basket page
=> You see translated option in combobox

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Galen Charlton 2014-03-13 15:32:44 UTC
Pushed to master.  Thanks, Fridolin!
Comment 7 Fridolin Somers 2014-06-12 07:38:16 UTC
Pushed to 3.14.x, will be in 3.14.08
Comment 8 Kyle M Hall 2014-06-13 12:39:02 UTC
Pushed to 3.12.x, will be in 3.12.13