Bug 11381 - IDreamBooks too close to title on bootstrap
Summary: IDreamBooks too close to title on bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-11 15:05 UTC by Nicole C. Engard
Modified: 2015-06-04 23:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
readometer on the title (96.61 KB, image/png)
2013-12-11 15:05 UTC, Nicole C. Engard
Details
Bug 11381 - IDreamBooks too close to title on bootstrap (3.02 KB, patch)
2014-01-10 17:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11381 - IDreamBooks too close to title on bootstrap (3.03 KB, patch)
2014-01-11 03:49 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 11381 - IDreamBooks too close to title on bootstrap (3.20 KB, patch)
2014-01-11 20:35 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2013-12-11 15:05:27 UTC
Created attachment 23396 [details]
readometer on the title

On the Bootstrap theme the IDreamBooks readometer is smack up against the title. In other themes it was aligned to the right so that the title was readable.  We don't need it aligned right, if that won't work, but I don't think it should be smack up against the title.
Comment 1 Owen Leonard 2014-01-10 17:49:30 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-01-11 03:49:09 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-01-11 20:35:45 UTC
Created attachment 24199 [details] [review]
[PASSED QA] Bug 11381 - IDreamBooks too close to title on bootstrap

Styling of IDreamBooks elements is not correct in the bootstrap theme
because the relevant CSS was not transferred from the prog theme. This
patch adds it back.

To test, switch to the bootstrap theme and enable IDreamBooks system
preferences in the OPAC, particularly IDreamBooksReadometer. Find a book
in the OPAC which shows IDreamBooks review data and confirm that
everything looks correct.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described. Tested with "The help".

http://bugs.koha-community.org/show_bug.cgi?id=11281
Comment 4 Galen Charlton 2014-01-13 22:01:20 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-03-07 08:16:45 UTC
Patch pushed to 3.14.x, will be in 3.14.5