Now that DBIx::Class is integrated into Koha, C4::SQLHelper should be removed and replaced with use of DBIC. Why? Now that we have a real ORM, there is no need for a bespoke, imperfect DBMS abstraction module. The following files reference C4::SQLHelper: C4/Acquisition.pm C4/Budgets.pm C4/Contract.pm C4/Members.pm C4/SQLHelper.pm C4/Suggestions.pm Koha/Borrower/Modifications.pm admin/aqbudgetperiods.pl t/db_dependent/SQLHelper.t
Created attachment 30201 [details] [review] Bug 11385: SQLHelper removed This patch removes the SQLHelper module, which has been replaced by DBIx::Class. Test plan : 1) Apply the patchs : - Contract : 12493 (UT), 12487 - Borrower::Modifications : 12623 - Acquisition : 12626 - Suggestions : 12445 (UT), 12627 - Members : 12457(UT), 12633 2) Verify there are no uses of SQLHelper with : git grep "SQLHelper"
This depends on a report without patches in status Assigned. Moving status to BLOCKED
Created attachment 37750 [details] [review] Bug 12633: Remove SQLHelper in C4::Members This is the only places where SQLHelper is still called. The C4::Members::Search is not used anymore, but ModMember and AddMember. This patch replaced the calls to SQLHelper to use DBIX::Class. TODO: Move them to Koha::Borrower. Test plan: 1/ Make sure the patron search still works (no changes expected since the code was not in used). 2/ Add a patron with all fields filled 3/ Add another patron with some fields filled 4/ Update them with other values 5/ Delete them You should not get any errors.
Created attachment 37752 [details] [review] Bug 11385: Remove SQL::Helper At this point, no occurrence of SQL::Helper should exist. Let's remove the package and tests. Test plan: git grep SQLHelper and git grep InTable Should not return anything in the Koha code.
Created attachment 38699 [details] [review] [PASSED QA] Bug 11385: Remove SQL::Helper At this point, no occurrence of SQL::Helper should exist. Let's remove the package and tests. Test plan: git grep SQLHelper and git grep InTable Should not return anything in the Koha code. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 38700 [details] [review] [SIGNED OFF] Bug 11385: Remove SQL::Helper At this point, no occurrence of SQL::Helper should exist. Let's remove the package and tests. Test plan: git grep SQLHelper and git grep InTable Should not return anything in the Koha code. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 38944 [details] [review] [PASSED QA] Bug 11385: Remove SQL::Helper At this point, no occurrence of SQL::Helper should exist. Let's remove the package and tests. Test plan: git grep SQLHelper and git grep InTable Should not return anything in the Koha code. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Good job Jonathan!