The mandatory fields on the subscription add form are not highlighting when you miss to enter data in one. Also, they are using (*) instead of the standard formatting.
Hi Katrin, What is the "standard formatting" exactly? Text in red, followed by "Required" ? What do you mean by "[they] are not highlighting when you miss to enter data" ? Is there a form in Koha that do that already ?
Hi Julian, take a look at the administration > branches form. There is a newer Javascript library that can be used to achieve these things in Koha. The bug is here: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6209 CCing Owen as the expert :) There is another thing about the form that troubles me - the date fields are now readonly. This is an accessibility problem as not everyone is able to use the date plugin. Could you reconsider those? I think we have other examples that allow direct entry of dates. (I can file a separate bug later).
> There is another thing about the form that troubles me - the date > fields are now readonly. This is an accessibility problem as not > everyone is able to use the date plugin. Could you reconsider those? Do you mean this is a problem when Javascript is disabled? Is it OK if date fields are enabled by default, and then set readonly by Javascript ?
I think as Koha relies heavily on Javascript turning off Javascript is not an option, also modern tools seem to support it to some level. As I understood it the problem is that using the date widget with a screenreader or braille line is not possible - so typing in the date directly is what should be a valid alternative.
Created attachment 23671 [details] [review] Bug 11386: Use jQuery.validate plugin for subscription add/edit form and remove readonly attribute on date fields, as datepicker is not available for everyone.
Created attachment 26219 [details] [review] [SIGNED-OFF] Bug 11386 - Mandatory fields in subscription add form should use standard formatting Use jQuery.validate plugin for subscription add/edit form and remove readonly attribute on date fields, as datepicker is not available for everyone. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 26312 [details] [review] [PASSED QA] Bug 11386 - Mandatory fields in subscription add form should use standard formatting Use jQuery.validate plugin for subscription add/edit form and remove readonly attribute on date fields, as datepicker is not available for everyone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests, and QA script.
Pushed to master. Thanks, Julian!