Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive this string change is worth.
Created attachment 23576 [details] [review] Bug 11400: Show "Login as a different user" instead of "Logout" if not enough premissions Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive this string change is worth. Simple and disputable string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba
Created attachment 23872 [details] [review] Bug 11400: Show "Login as a different user" instead of "Logout" if not enough premissions Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive this string change is worth. Simple and disputable string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 23912 [details] screenshot of login page in Chromium I was about to pass it, as I like the idea, but it doesn't work very well with the limited width of the login box (see screenshot). In Firefox "different user" is on a new line for me. The screenshot is taken in Chromium. In German the text would even get a bit longer, if you translated it directly. Maybe center both buttons on their own line?
Created attachment 23952 [details] [review] Bug 11400: Show "Log in as a different user" in the error message instead of the "Logout" button Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive the logout button is redundant. And also "Log in as a different user" tells the user more about its options on the scenario. Simple and disputable usability/string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba
The patch works, but I'm not sure that this improves the current behaviour. I suppose the "Logout" button was added so that people could end their session here? I suppose they could just use the "Previous page" button and then logout from there (or continue doing what they were doing). In any case, "Log in" should probably be "Login" to match the other button. Also, we might consider something more explanatory like: "Error: You do not have permission to access this page. Login as a different user or return to the previous page." Maybe even moving the "Previous page" button down to the bottom left corner to improve the aesthetic of the page?
(In reply to David Cook from comment #5) > I suppose the "Logout" button was added so that people could end their > session here? Yeah I've always wondered what the workflow there was: "Ooops, I reached a page I can't access. Instead of logging in as a different user right now I'm going to log out completely and give up." > In any case, "Log in" should probably be "Login" to match the other button. Actually now that I look at it I think they should both be "Log in." "Login" should be used as a noun, "Log in" as a verb. > Also, we might consider something more explanatory like: > "Error: You do not have permission to access this page. > > Login as a different user or return to the previous page." > > Maybe even moving the "Previous page" button down to the bottom left corner > to improve the aesthetic of the page? I like these suggestions.
Scrolling through the last comments, I also agree that the Previous page button is not really placed very nice (not to say ugly :) Login is no verb, so it should be Log in. (Note that this occurs in more places.) And if you add the sentence "Log in as a different user", what about adding the other possibility of going back too? So: Log in as a different user or go back to the previous page? On the other hand, adding even more text and buttons will probably not improve the current form. So this is a hard one. Moving it to In Discussion
Another bug stuck in 'In Discussion'... any further thoughts/developments people?
Created attachment 36001 [details] [review] Bug 11400 - Follow-up for nicer design This patch tries to get the Bug out of "In discussion" by changing the design a little bit.
I hope it is OK to switch to "Needs Signoff"
(In reply to Marc Véron from comment #10) > I hope it is OK to switch to "Needs Signoff" It is!
Created attachment 36015 [details] [review] Bug 11400: Show "Log in as a different user" in the error message instead of the "Logout" button Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive the logout button is redundant. And also "Log in as a different user" tells the user more about its options on the scenario. Simple and disputable usability/string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 36016 [details] [review] Bug 11400 - Follow-up for nicer design This patch tries to get the Bug out of "In discussion" by changing the design a little bit. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
It does not look much nicer for me :) Ccing Owen to get his opinion.
Created attachment 36066 [details] [review] [PASSED QA] Bug 11400: Show "Log in as a different user" in the error message instead of the "Logout" button Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive the logout button is redundant. And also "Log in as a different user" tells the user more about its options on the scenario. Simple and disputable usability/string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 36067 [details] [review] [PASSED QA] Bug 11400 - Follow-up for nicer design This patch tries to get the Bug out of "In discussion" by changing the design a little bit. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
See comment 14, I was waiting for feedbacks.
Patches pushed to master. Thanks Marc!