The cataloging search is passing the incorrect variable to SimpleSearch. I'm sure this is causing other issues, but the one I have identified is that any searches with an "&" in them return no results.
Created attachment 23614 [details] [review] Bug 11410 - Cataloging search finds no results for searches with ampersands The cataloging search is passing the incorrect variable to SimpleSearch. I'm sure this is causing other issues, but the one I have identified is that any searches with an "&" in them return no results. Test Plan: 1) Catalog a new record titled "Cats & Dogs" 2) Rebuild your zebra index so this record is indexed 3) Browse to cataloguing/addbooks.pl 4) Search for "Cats & Dogs" 5) Notice you get no results 6) Apply this patch 7) Repeat the search 8) Notice your result now shows up!
I have followed this test plan, and can confirm the patch fixes this bug.
This is working.
Created attachment 23722 [details] [review] Bug 11410 - Cataloging search finds no results for searches with ampersands The cataloging search is passing the incorrect variable to SimpleSearch. I'm sure this is causing other issues, but the one I have identified is that any searches with an "&" in them return no results. Test Plan: 1) Catalog a new record titled "Cats & Dogs" 2) Rebuild your zebra index so this record is indexed 3) Browse to cataloguing/addbooks.pl 4) Search for "Cats & Dogs" 5) Notice you get no results 6) Apply this patch 7) Repeat the search 8) Notice your result now shows up! Signed-off-by: Heather Braum <hbraum@nekls.org> Signed-off-by: Suzanne Fayle <sfayle@roseman.edu>
Created attachment 23742 [details] [review] [PASSED QA] Bug 11410 - Cataloging search finds no results for searches with ampersands The cataloging search is passing the incorrect variable to SimpleSearch. I'm sure this is causing other issues, but the one I have identified is that any searches with an "&" in them return no results. Test Plan: 1) Catalog a new record titled "Cats & Dogs" 2) Rebuild your zebra index so this record is indexed 3) Browse to cataloguing/addbooks.pl 4) Search for "Cats & Dogs" 5) Notice you get no results 6) Apply this patch 7) Repeat the search 8) Notice your result now shows up! Signed-off-by: Heather Braum <hbraum@nekls.org> Signed-off-by: Suzanne Fayle <sfayle@roseman.edu> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This works as described, passes all tests and QA script. Note: Because $query = $builtquery when the QueryParser is used, this problem is only visible when UseQueryParser is set to "Don't try".
Pushed to master. Thanks, Kyle!
Patch pushed to 3.14.x, will be in 3.14.2
This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Kyle!