Bug 11415 - SCO has no option to disable automatic receipt printing
Summary: SCO has no option to disable automatic receipt printing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: JaTara Barnes
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-18 12:41 UTC by Kyle M Hall
Modified: 2014-12-07 20:05 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Implements syspref for SCO receipt printing (3.89 KB, patch)
2014-01-05 06:47 UTC, JaTara Barnes
Details | Diff | Splinter Review
Implements syspref for SCO receipt printing - updated to change default to ON (1.30 KB, patch)
2014-01-08 18:09 UTC, JaTara Barnes
Details | Diff | Splinter Review
Implements syspref for SCO receipt printing -- updated default value + template (2.68 KB, patch)
2014-01-09 04:34 UTC, JaTara Barnes
Details | Diff | Splinter Review
Implements syspref for SCO receipt -- added code to prog (1.29 KB, patch)
2014-01-09 05:12 UTC, JaTara Barnes
Details | Diff | Splinter Review
Bug 11415: Add syspref to toggle receipt printing for self-check (3.88 KB, patch)
2014-01-09 05:31 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11415: Add syspref to toggle SCO receipt printing Simple change to updatedatabase.pl to set SCO receipt printing as default (1.34 KB, patch)
2014-01-09 05:31 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11415: Add syspref to toggle SCO receipt printing (2.71 KB, patch)
2014-01-09 05:31 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11415: Add syspref to toggle SCO receipt printing (1.33 KB, patch)
2014-01-09 05:31 UTC, Mark Tompsett
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11415: Add syspref to toggle receipt printing for self-check (3.89 KB, patch)
2014-01-09 05:35 UTC, Mark Tompsett
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11415: Add syspref to toggle SCO receipt printing (1.36 KB, patch)
2014-01-09 05:35 UTC, Mark Tompsett
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11415: Add syspref to toggle SCO receipt printing (2.74 KB, patch)
2014-01-09 05:35 UTC, Mark Tompsett
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11415: Add syspref to toggle SCO receipt printing (1.39 KB, patch)
2014-01-09 05:35 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11415: Add syspref to toggle SCO receipt printing (5.42 KB, patch)
2014-01-10 14:12 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11415: Add syspref to toggle SCO receipt printing (5.48 KB, patch)
2014-01-10 14:22 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11415 [QA Followup] - Add syspref to toggle SCO receipt printing (2.42 KB, patch)
2014-01-10 14:23 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-12-18 12:41:21 UTC
There are libraries use Koha's self checkout system without having receipt printers connected to them. The prompt for print a receipt from sco should be optional and controlled by a system preference.
Comment 1 JaTara Barnes 2014-01-05 06:47:08 UTC Comment hidden (obsolete)
Comment 2 JaTara Barnes 2014-01-06 01:11:11 UTC
Test Case: 

1. Log into self-check as normal.
2. Click the "Finish" button.
3. Notice that receipt dialog pops up.
4. Apply patch.
5. Run updatedatabase.pl
6. Set the SelfCheckReceiptPrompt syspref to "Don't show"
6. Log into self-check.
7. Click the "Finish" button.
8. Verify that the receipt dialog does NOT pop up.
Comment 3 Chris Cormack 2014-01-06 08:21:14 UTC
Comment on attachment 23904 [details] [review]
Implements syspref for SCO receipt printing

Review of attachment 23904 [details] [review]:
-----------------------------------------------------------------

::: installer/data/mysql/updatedatabase.pl
@@ +7886,5 @@
>  }
>  
> +$DBversion = "3.15.00.XXX";
> +if(CheckVersion($DBversion)) {
> +   $dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES('SelfCheckReceiptPrompt', '0', 'NULL', 'If ON, print receipt dialog pops up when self checkout is finished.', 'YesNo');");

This all looks good, and works well. Our rule of thumb though is to not change behaviour. This syspref is set off, so once you upgrade you will no longer get the prompt showing up.
I think it should go into the update as on, so the behaviour doesn't change on upgrade, people can switch it off.

It can go in off for new installs though.
Comment 4 JaTara Barnes 2014-01-08 18:09:57 UTC Comment hidden (obsolete)
Comment 5 JaTara Barnes 2014-01-09 04:34:50 UTC Comment hidden (obsolete)
Comment 6 JaTara Barnes 2014-01-09 05:12:30 UTC Comment hidden (obsolete)
Comment 7 Mark Tompsett 2014-01-09 05:31:00 UTC Comment hidden (obsolete)
Comment 8 Mark Tompsett 2014-01-09 05:31:03 UTC Comment hidden (obsolete)
Comment 9 Mark Tompsett 2014-01-09 05:31:06 UTC Comment hidden (obsolete)
Comment 10 Mark Tompsett 2014-01-09 05:31:09 UTC Comment hidden (obsolete)
Comment 11 Mark Tompsett 2014-01-09 05:35:47 UTC Comment hidden (obsolete)
Comment 12 Mark Tompsett 2014-01-09 05:35:50 UTC Comment hidden (obsolete)
Comment 13 Mark Tompsett 2014-01-09 05:35:53 UTC Comment hidden (obsolete)
Comment 14 Mark Tompsett 2014-01-09 05:35:55 UTC Comment hidden (obsolete)
Comment 15 Mark Tompsett 2014-01-09 05:51:32 UTC
REVISED TEST PLAN
=================
0. ~/qa-test-tools/koha-qa.pl -v 2 -c 4
   NOTE: Fix tabs.
1. Log into self-check as normal.
   (https://.../cgi-bin/koha/sco/sco-main.pl)
2. Check something out.
2. Click the "Finish" button.
3. Notice that receipt dialog pops up.
4. Apply patch.
5. Run updatedatabase.pl
6. Set the SelfCheckReceiptPrompt syspref to "Don't show"
7. Log into self-check.
8. Check something out.
9. Click the "Finish" button.
10. Verify that the receipt dialog does NOT pop up.
11. Set the SelfCheckReceiptPrompt syspref to "Don't show"
12. Log into self-check.
13. Check something out.
14. Click the "Finish" button.
15. Verify that the receipt dialog does NOT pop up.
Comment 16 Mark Tompsett 2014-01-09 05:54:32 UTC
Oops... got hit by the cut-and-paste problem. Fixed step 11. :)

REVISED TEST PLAN
=================
0. ~/qa-test-tools/koha-qa.pl -v 2 -c 4
   NOTE: Fix tabs.
1. Log into self-check as normal.
   (https://.../cgi-bin/koha/sco/sco-main.pl)
2. Check something out.
2. Click the "Finish" button.
3. Notice that receipt dialog pops up.
4. Apply patch.
5. Run updatedatabase.pl
6. Set the SelfCheckReceiptPrompt syspref to "Don't show"
7. Log into self-check.
8. Check something out.
9. Click the "Finish" button.
10. Verify that the receipt dialog does NOT pop up.
11. Set the SelfCheckReceiptPrompt syspref to "Show"
12. Log into self-check.
13. Check something out.
14. Click the "Finish" button.
15. Verify that the receipt dialog does NOT pop up
Comment 17 Kyle M Hall 2014-01-10 14:12:17 UTC Comment hidden (obsolete)
Comment 18 Kyle M Hall 2014-01-10 14:22:42 UTC
Created attachment 24131 [details] [review]
Bug 11415: Add syspref to toggle SCO receipt printing

Toggled SCO receipt printing to be on by default for upgrades
in updatedatabase.pl.

Updated files to set default to 1 in sysprefs.sql.  Also added
code to read the system preference on the template page.

Added code to update prog theme with same changes as the
bootstrap theme.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passes koha-qa.pl, works as advertised. No regressions noted.
Comment 19 Kyle M Hall 2014-01-10 14:23:05 UTC
Created attachment 24132 [details] [review]
Bug 11415 [QA Followup] - Add syspref to toggle SCO receipt printing
Comment 20 Katrin Fischer 2014-01-11 15:13:15 UTC
Now Kyle was faster with doing QA:) Welcome JaTara!
Comment 21 Galen Charlton 2014-01-23 17:13:56 UTC
Pushed to master.  Congratulations on having your first patch accepted into Koha, JaTara!
Comment 22 Fridolin Somers 2014-05-16 10:38:07 UTC
Pushed to 3.14.x, will be in 3.14.07.

(created updatabase 3.14.06.001)