Bug 11416 - Serials editor improperly hides fields
Summary: Serials editor improperly hides fields
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-18 13:37 UTC by Kyle M Hall
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11416 - Serials editor improperly hides fields (1.77 KB, patch)
2013-12-18 13:41 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11416 - Serials editor improperly hides fields (1.82 KB, patch)
2013-12-20 16:06 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11416 - Serials editor improperly hides fields (1.95 KB, patch)
2013-12-23 14:30 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-12-18 13:37:08 UTC
In serials/serials-edit.pl, if a field is hidden from the OPAC, it will not display in the editor, even if the field is marked as visible in the staff intranet and editor. However, the field is still displayed correctly in the items editor ( additem.pl ).
Comment 1 Kyle M Hall 2013-12-18 13:41:12 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2013-12-20 16:06:08 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-12-23 14:30:10 UTC
Created attachment 23786 [details] [review]
Bug 11416 - Serials editor improperly hides fields

In serials/serials-edit.pl, if a field is hidden from the OPAC, it will
not display in the editor, even if the field is marked as visible in the
staff intranet and editor. However, the field is still displayed
correctly in the items editor ( additem.pl ).:

Test Plan:
1) Select an item-level field ( e.g. non-public note )
2) Create a serial using the default framework ( or one of your choice )
3) For that framework, mark the chosen field as visible from the
intranet and editor, but not the opac.
4) Recieve an item for this serial, note your field does not display
5) Use the biblio item editor to add an item ( additem.pl ), not the
field displayes
6) Apply this patch
7) Repeat step 4, not the field displayes

Signed-off-by: Kim Schwant <kim.schwant@courts.in.gov>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
PrepareItemrecordDisplay is only used for editor (-4 < hidden < 4)
Comment 4 Galen Charlton 2014-04-18 21:39:58 UTC
Pushed to master.  Thanks, Kyle!
Comment 5 Fridolin Somers 2014-08-06 10:33:36 UTC
Pushed to 3.14.x, will be in 3.14.10
Comment 6 Kyle M Hall 2014-08-13 14:39:14 UTC
Picked for 3.12.15!