Bug 11419 - z39.50 searches not displaying errors
Summary: z39.50 searches not displaying errors
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Z39.50 / SRU / OpenSearch Servers (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-18 19:41 UTC by Kyle M Hall
Modified: 2015-06-04 23:23 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11419 - z39.50 searches not displaying errors (1.21 KB, patch)
2013-12-18 19:47 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11419 - z39.50 searches not displaying errors (1.26 KB, patch)
2013-12-20 16:03 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 11419 - z39.50 searches not displaying errors (1.48 KB, patch)
2013-12-26 18:07 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-12-18 19:41:55 UTC
When a z39.50 server isn't able to be searched successfully, the yellow error box comes up empty.
Comment 1 Kyle M Hall 2013-12-18 19:47:14 UTC Comment hidden (obsolete)
Comment 2 Nora Blake 2013-12-18 20:47:50 UTC
This patch looks good on our test system.

It makes us happy and we'd like to approve it.

Thanks,

Nora Blake
MassCat
Comment 3 Kyle M Hall 2013-12-20 16:03:46 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-12-26 17:59:19 UTC
I think the empty dialog box indicates some kind of bug, so changing this to 'minor'
Comment 5 Katrin Fischer 2013-12-26 18:07:17 UTC
Created attachment 23821 [details] [review]
[PASSED QA] Bug 11419 - z39.50 searches not displaying errors

When a z39.50 server isn't able to be searched successfully, the yellow
error box comes up empty.

Test Plan:
1) Go to Administration/z39.50 servers
2) Create a fake z39.50 server with a made up address
3) Go to cataloging, search only that server
4) Note the empty yellow alert box
5) Apply this patch
6) Re-run the search, not the alert box has a message in it now

Signed-off-by: Nora Blake <nblake@masslibsystem.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
Works according to test plan.
When one of the selected servers gives result no dialog
box is shown before and after applying the patch.
Comment 6 Katrin Fischer 2013-12-26 18:08:21 UTC
Thank you for your sign-off Nora!
Comment 7 Galen Charlton 2013-12-27 00:27:45 UTC
Pushed to master.  Thanks, Kyle!
Comment 8 Fridolin Somers 2014-01-16 16:49:44 UTC
Patch pushed to 3.14.x, will be in 3.14.2.
Comment 9 Tomás Cohen Arazi 2014-02-07 14:56:06 UTC
This patch has been pushed to 3.12.x, will be in 3.12.11.

Thanks Kyle!