Tests 22 and 23 failed on my database because I had a few subscriptions in my database. After setting the subscription.enddate far into the future the tests passed again. ok 22 - search for subscriptions by expiration date ok 23 - search for subscriptions by expiration date Maybe cleaning the subscription table within the transaction before running the test would fix this.
Yep, if you have an old subscription that ended before 2013-12-31 test 22 will fail. If one is older than 2013-08-15 23 will also fail.
Created attachment 23886 [details] [review] Bug 11457 : Clearing subscription table so tests pass correctly To test 1/ Add a subscription in the serials module, with an end date before 2013-08-01 2/ run prove -v t/db_dependent/Bookseller.t Notice tests 22 and 23 fail 3/ Apply patch 4/ run test again 5/ Notice tests succeed
Created attachment 23890 [details] [review] [SIGNED OFF] Bug 11457 : Clearing subscription table so tests pass correctly To test 1/ Add a subscription in the serials module, with an end date before 2013-08-01 2/ run prove -v t/db_dependent/Bookseller.t Notice tests 22 and 23 fail 3/ Apply patch 4/ run test again 5/ Notice tests succeed Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tests now clean the subscription table before running the tests, so that the will always pass.
Created attachment 24100 [details] [review] Bug 11457 : Clearing subscription table so tests pass correctly To test 1/ Add a subscription in the serials module, with an end date before 2013-08-01 2/ run prove -v t/db_dependent/Bookseller.t Notice tests 22 and 23 fail 3/ Apply patch 4/ run test again 5/ Notice tests succeed Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tests now clean the subscription table before running the tests, so that the will always pass. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Chris!
Patch pushed to 3.14.x, will be in 3.14.4.