Bug 11463 - GetItem must use item-level_itypes syspref
Summary: GetItem must use item-level_itypes syspref
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-31 11:24 UTC by Fridolin Somers
Modified: 2017-06-14 22:11 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 11463 - GetItem must use item-level_itypes syspref (998 bytes, patch)
2013-12-31 11:50 UTC, Fridolin Somers 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2013-12-31 11:24:39 UTC 
In GetItem, the key itype comes from items.itype and if not defined from biblioitems.itemtype.
This code should be based on item-level_itypes syspref.
Comment 1 Fridolin Somers 2013-12-31 11:36:09 UTC 
See Bug 9532 comments :
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532#c13
Comment 2 Fridolin Somers 2013-12-31 11:50:00 UTC 
Created attachment 23878 [details] [review]
Bug 11463 - GetItem must use item-level_itypes syspref
Comment 3 Fridolin Somers 2013-12-31 11:51:05 UTC 
I've attached the patch but it surely needs a huge test plan.
Comment 4 Tomás Cohen Arazi (tcohen) 2016-11-08 18:00:55 UTC 
This is already fixed, now that GetItem calls Koha::Items->find()->effective_itemtype