Some strings in Javascript are not properly formatted for translation: $(".title").append('<a href="'+json.book.detail_link+'" id="idreambooksreadometer"><img src="http://idreambooks.com/remotereadometer/'+isbn+'.jpg" alt="'+json.book.title+' by '+json.book.author+'" title="Rating based on reviews of '+json.book.title+'"></a>'); $("#catalogue_detail_biblio").append("<span class='idreambookssummary results_summary'><a href='"+json.book.detail_link+"'><img src='"+json.book.to_read_or_not_small+"' alt='"+json.book.title+" by "+json.book.author+"' title='Rating based on reviews of "+json.book.title+"'>"+json.book.rating+"%</a> <a href='http://www.idreambooks.com/'>rating based on reviews at iDreamBooks.com</a></span>"); if (arrPagination[i].author) html += "<br /> by " + arrPagination[i].author;
Created attachment 39968 [details] [review] Bug Untranslatable srings in opac-detail.tt (IDreamBooks*, OpacBrowseResults) Patch marks several strings in the Javascript on the OPAC detail and result page for translation. 1) IDreamBooks* - Activate the 3 IDreamBooks* system preferences - Check the 'cloud' and additional content shows up correctly on the detail and result pages - Verify everything works as expected and the same as without the patch 2) OpacBrowseResults - Activate OpacBrowseResults - Do various searches - Verify the nex, previous, browse result list features still work the same as without the patch Bonus: Check new strings appear in the .po files by updating one language with the patch applied (perl translate update de-DE)
Created attachment 40251 [details] [review] Bug Untranslatable srings in opac-detail.tt (IDreamBooks*, OpacBrowseResults) Patch marks several strings in the Javascript on the OPAC detail and result page for translation. 1) IDreamBooks* - Activate the 3 IDreamBooks* system preferences - Check the 'cloud' and additional content shows up correctly on the detail and result pages - Verify everything works as expected and the same as without the patch 2) OpacBrowseResults - Activate OpacBrowseResults - Do various searches - Verify the nex, previous, browse result list features still work the same as without the patch Bonus: Check new strings appear in the .po files by updating one language with the patch applied (perl translate update de-DE) NOTE: Really should have read the test plan more closely. I couldn't find the 'Go to detail:' section, until I clicked 'Browse results'. Did not test additional language po files. Did trigger all code segments. http://bugs.koha-community.org/show_bug.cgi?id=11467 Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 40253 [details] [review] Bug 11467: Bug Untranslatable srings in opac-detail.tt (IDreamBooks*, OpacBrowseResults) Patch marks several strings in the Javascript on the OPAC detail and result page for translation. 1) IDreamBooks* - Activate the 3 IDreamBooks* system preferences - Check the 'cloud' and additional content shows up correctly on the detail and result pages - Verify everything works as expected and the same as without the patch 2) OpacBrowseResults - Activate OpacBrowseResults - Do various searches - Verify the nex, previous, browse result list features still work the same as without the patch Bonus: Check new strings appear in the .po files by updating one language with the patch applied (perl translate update de-DE) NOTE: Really should have read the test plan more closely. I couldn't find the 'Go to detail:' section, until I clicked 'Browse results'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Maybe the format js function could have been used to permit a better translation in some languages.
Hm, I forgot about that newer option.
Patch pushed to master. Thanks Katrina!
Pushed to 3.20.x will be in 3.20.2
Pushed to 3.18.x, will be in 3.18.09
Contains string changes, holding till 3.16.14