When registering a new account from the OPAC the title pull down offers 2 empty options if BorrowerTitle is configured with one or more entries.
Created attachment 24165 [details] [review] Bug 11476 - Opac self registration title pull down offers 2 empty options If you have patron titles enabled, the OPAC patron details form lists 2 empty spaces instead of 1. An empty option is passed by the script, so the template does not need to include one. To test you must have at least one patron title set in BorrowersTitles system preference and OPACPatronDetails must be set to "allow." 1. Apply the patch 2. Log in to the OPAC 3. Click the "personal details" tab. 4. Click the "salutation" dropdown. There should be only one blank line preceding the existing titles. Test in both prog and bootstrap.
Created attachment 24190 [details] [review] Bug 11476 - Opac self registration title pull down offers 2 empty options If you have patron titles enabled, the OPAC patron details form lists 2 empty spaces instead of 1. An empty option is passed by the script, so the template does not need to include one. To test you must have at least one patron title set in BorrowersTitles system preference and OPACPatronDetails must be set to "allow." 1. Apply the patch 2. Log in to the OPAC 3. Click the "personal details" tab. 4. Click the "salutation" dropdown. There should be only one blank line preceding the existing titles. Test in both prog and bootstrap. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 24197 [details] [review] [PASSED QA] Bug 11476 - Opac self registration title pull down offers 2 empty options If you have patron titles enabled, the OPAC patron details form lists 2 empty spaces instead of 1. An empty option is passed by the script, so the template does not need to include one. To test you must have at least one patron title set in BorrowersTitles system preference and OPACPatronDetails must be set to "allow." 1. Apply the patch 2. Log in to the OPAC 3. Click the "personal details" tab. 4. Click the "salutation" dropdown. There should be only one blank line preceding the existing titles. Test in both prog and bootstrap. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described for existing and creating new accounts.
Pushed to master. Thanks, Owen!
Patch pushed to 3.14.x, will be in 3.14.5
Patch pushed to 3.12.x, will be in 3.12.13