Bug 11476 - Opac self registration title pull down offers 2 empty options
Summary: Opac self registration title pull down offers 2 empty options
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-05 21:29 UTC by Katrin Fischer
Modified: 2015-06-04 23:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11476 - Opac self registration title pull down offers 2 empty options (2.67 KB, patch)
2014-01-10 17:02 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11476 - Opac self registration title pull down offers 2 empty options (2.69 KB, patch)
2014-01-11 04:20 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 11476 - Opac self registration title pull down offers 2 empty options (2.82 KB, patch)
2014-01-11 19:55 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-01-05 21:29:22 UTC
When registering a new account from the OPAC the title pull down offers 2 empty options if BorrowerTitle is configured with one or more entries.
Comment 1 Owen Leonard 2014-01-10 17:02:42 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-01-11 04:20:18 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-01-11 19:55:48 UTC
Created attachment 24197 [details] [review]
[PASSED QA] Bug 11476 - Opac self registration title pull down offers 2 empty options

If you have patron titles enabled, the OPAC patron details form lists 2
empty spaces instead of 1. An empty option is passed by the script, so
the template does not need to include one.

To test you must have at least one patron title set in BorrowersTitles
system preference and OPACPatronDetails must be set to "allow."

1. Apply the patch
2. Log in to the OPAC
3. Click the "personal details" tab.
4. Click the "salutation" dropdown. There should be only one blank line
   preceding the existing titles.

Test in both prog and bootstrap.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described for existing and creating new accounts.
Comment 4 Galen Charlton 2014-01-17 05:38:10 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-03-25 08:46:21 UTC
Patch pushed to 3.14.x, will be in 3.14.5
Comment 6 Kyle M Hall 2014-06-02 16:25:20 UTC
Patch pushed to 3.12.x, will be in 3.12.13