Bug 11482 - new reservation syspref PickupHoldOnlyFromItemBranches
Summary: new reservation syspref PickupHoldOnlyFromItemBranches
Status: RESOLVED MOVED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Koha Team University Lyon 3
QA Contact: Testopia
URL:
Keywords:
Depends on: 11481
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-06 17:26 UTC by Koha Team University Lyon 3
Modified: 2023-06-10 20:15 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug-11482 PickupHoldOnlyFromItemBranches new syspref (25.24 KB, patch)
2014-01-06 17:38 UTC, Koha Team University Lyon 3
Details | Diff | Splinter Review
Bug 11482 PickupHoldOnlyFromItemBranches new syspref (25.24 KB, patch)
2014-01-10 09:52 UTC, Koha Team University Lyon 3
Details | Diff | Splinter Review
Bug 11482 PickupHoldOnlyFromItemBranches new syspref (25.26 KB, patch)
2014-03-11 14:41 UTC, Koha Team University Lyon 3
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Koha Team University Lyon 3 2014-01-06 17:26:27 UTC
warning : even if this patch and Bug 11481 can work separately it's necessary to first install Bug 11481 in order to avoid conflict and applying patch issues.

The use of this new syspref assumes that other sysprefs OPACAllowUserToChooseBranch and canreservefromotherbranches are set on.
it introduces the following behavior about reserves :
You can't choose whatever branch as your pickup location. It must be a holding branch of an item.
Either you don't mind picking the item at one branch or another and you ask for the very first available item or you select a specific branch and you will get the first checked in item in it.
Multiholds is not possible from the pro interface (Place hold button is hidden in the results list).
In the hold form the pickup list display only the branch(es) where the items are from.
If a branch has no circulation rule allowing holds for its documents, it does not appear in the list.

Test plan :
1) Enable RequestOnOpac OPACAllowUserToChooseBranch canreservefromotherbranches and PickupHoldOnlyFromItemBranches syspref
2) Choose one borrower (patron1) to place holds : get his category, login and pasword. 
3) Go to Administration/Circulation and fine rules
4) in the ALL libraries table (selected by default) set a circulation rule for the borrower category adding an amount of holds in "Holds allowed" column
You can set only one rule for a beginning with itemtype as All or several rules with different item type.
5) In the pro interface, choose a record with some items of different branches.
6) check out some items. do not forget to checkout items on their very homebranch
7) go to opac and search for the detailed record
8) Place a hold and authenticate as patron1. In the pickup list, you must see as options, only the branches of the items. You can choose either the first available item from all these branches or first from a specific one of them. try 'first available'.
9) Go to patron1 user file and click the tab Holds : the hold had been recorded. Pickup location is 'Whatever location from the first available'.
10) reconnect as admin and check in one of the items, a message box appears : confirm the hold.
11) Reconnect as Patron1, go back to the user file and check that the pickup location zone now displays the branch of the returned item.
cancel the hold
12) redo a test from stage 6 selecting a specific branch in stage 8
13) go to pro interface to the detailed record, click the Holds tab and enter patron1 in text box
14) the holds form appears. The pickup location displays only the branches of items. Select an option and confirm the hold.
15) the holds table now display a line for the new recorded holds with patron1 name. Check that pickup location list is still restricted to item branches.
Comment 1 Koha Team University Lyon 3 2014-01-06 17:38:09 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-01-09 14:14:34 UTC
fatal: sha1 information is lacking or useless (C4/Reserves.pm).
Comment 3 Koha Team University Lyon 3 2014-01-10 09:52:54 UTC Comment hidden (obsolete)
Comment 4 Koha Team University Lyon 3 2014-03-11 14:41:45 UTC
Created attachment 26113 [details] [review]
Bug 11482 PickupHoldOnlyFromItemBranches new syspref

patch rebased
Comment 5 Koha Team University Lyon 3 2014-04-24 13:14:39 UTC
I drop this patch
Comment 6 Katrin Fischer 2023-06-10 20:15:09 UTC
I believe this is covered now in the circulation rules in the last table on the page with the pickup location rules.