Bug 11486 - Show renewal count on 'check out' and 'details' tabs in patron record
Summary: Show renewal count on 'check out' and 'details' tabs in patron record
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: David Cook
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-07 04:05 UTC by David Cook
Modified: 2014-12-07 20:07 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11486 - Show renewal count on 'check out' and 'details' tabs in patron record (7.22 KB, patch)
2014-01-07 04:14 UTC, David Cook
Details | Diff | Splinter Review
message not showing (20.17 KB, image/png)
2014-01-08 20:39 UTC, Nicole C. Engard
Details
[SIGNED-OFF] Bug 11486 - Show renewal count on 'check out' and 'details' tabs in patron record (7.31 KB, patch)
2014-01-09 15:01 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 11486 - Show renewal count on 'check out' and 'details' tabs in patron record (7.38 KB, patch)
2014-01-10 11:31 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11486: Don't display the number of remaining renewals if == 0 (4.29 KB, patch)
2014-01-10 11:32 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2014-01-07 04:05:10 UTC
A librarian has pointed out that the renewal count (2 of 3 renewals remaining) appears on the OPAC, but not on the staff client.

This will let librarians see at a glance how many renewals are left for a few scenarios (e.g. letting a patron know how many renewals they have left, knowing how close the patron is to their limit, etc).
Comment 1 David Cook 2014-01-07 04:14:27 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2014-01-08 20:39:03 UTC
Created attachment 24033 [details]
message not showing

This patch is awesome and works for everything - but not if the item is on hold.  See attached image.
Comment 3 David Cook 2014-01-09 00:19:47 UTC
(In reply to Nicole C. Engard from comment #2)
> Created attachment 24033 [details]
> message not showing
> 
> This patch is awesome and works for everything - but not if the item is on
> hold.  See attached image.

Nicole, that was intentional. If you look at the OPAC, you should see the same behaviour, because you shouldn't be able to renew an item that has been placed on hold.

I'll move this back to "Needs Signoff", but happy to have a discussion about this, if folks want.

I don't think there are cases where you can renew a book that is on hold for someone else, but perhaps I'm wrong?
Comment 4 Nicole C. Engard 2014-01-09 15:01:40 UTC
Created attachment 24093 [details] [review]
[SIGNED-OFF] Bug 11486 - Show renewal count on 'check out' and 'details' tabs in patron record

This patch adds the renewal count to the 'Check out' and "Details' tabs of the
patron record.

This information already exists in the OPAC view of the patron record. Since
librarians might be serving patrons in person who want to know this information
without looking it up online, it makes sense to show it in the staff client.

There may also be times where librarians want to see how many renewals
a patron has left, how many they've used already, etc. when making other
decisions.

_TEST PLAN_

Before applying:

1) Go to "Check out" with a patron that has some check outs before today
2) Add some check outs for today
*Ensure that all issues are for items that can be renewed*
3) Note that the Renew column just says '0' followed by a check box
4) Check the 'Detail' tab. It should say the same.

Apply the patch.

5) View the "Details" and "Check out" tabs again
6) Note that the renewal count now appears in the form resembling:
5 of 5 renewals remaining

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
All tests pass
Comment 5 Nicole C. Engard 2014-01-09 15:02:21 UTC
Signed off!

I'll report another bug - I think that just cause you can't renew doesn't mean you shouldn't see that you did renew :)
Comment 6 Jonathan Druart 2014-01-10 11:31:39 UTC
David,
Don't you think it is useless to display the information if not renewal is possible?
Comment 7 Jonathan Druart 2014-01-10 11:31:57 UTC
Created attachment 24114 [details] [review]
Bug 11486 - Show renewal count on 'check out' and 'details' tabs in patron record

This patch adds the renewal count to the 'Check out' and "Details' tabs of the
patron record.

This information already exists in the OPAC view of the patron record. Since
librarians might be serving patrons in person who want to know this information
without looking it up online, it makes sense to show it in the staff client.

There may also be times where librarians want to see how many renewals
a patron has left, how many they've used already, etc. when making other
decisions.

_TEST PLAN_

Before applying:

1) Go to "Check out" with a patron that has some check outs before today
2) Add some check outs for today
*Ensure that all issues are for items that can be renewed*
3) Note that the Renew column just says '0' followed by a check box
4) Check the 'Detail' tab. It should say the same.

Apply the patch.

5) View the "Details" and "Check out" tabs again
6) Note that the renewal count now appears in the form resembling:
5 of 5 renewals remaining

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
All tests pass

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 8 Jonathan Druart 2014-01-10 11:32:03 UTC
Created attachment 24115 [details] [review]
Bug 11486: Don't display the number of remaining renewals if == 0

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 9 David Cook 2014-01-13 22:48:03 UTC
(In reply to Jonathan Druart from comment #6)
> David,
> Don't you think it is useless to display the information if not renewal is
> possible?

Honestly, I don't have a strong opinion either way. I was just trying to stay consistent with current behaviour. 

I'm more than happy for Nicole to open a bug to change current behaviour in the OPAC (and the staff client as well presuming this gets in).
Comment 10 Galen Charlton 2014-01-23 17:41:06 UTC
Pushed to master.  Thanks, David!