Bug 11487 - Untranslatable tooltip "Dates of birth should be entered in the format ..."
Summary: Untranslatable tooltip "Dates of birth should be entered in the format ..."
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-07 12:30 UTC by paxed
Modified: 2014-12-07 20:02 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 11487: Untranslatable tooltip "Dates of birth should be entered in the format ..." (1.29 KB, patch)
2014-01-14 22:40 UTC, Aleisha Amohia 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-01-07 12:30:26 UTC 
The following text is not picked up by the translation toolchain:

koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:                            content: 'Dates of birth should be entered in the format "[% format %]"',
Comment 1 Aleisha Amohia 2014-01-14 22:40:03 UTC 
Created attachment 24322 [details] [review]
Bug 11487:  Untranslatable tooltip "Dates of birth should be entered in the format ..."

Test plan:
1. Test that tooltip still shows
2. We couldn't test the translations so please can someone else test it?
Comment 2 Jonathan Druart 2014-01-15 14:18:07 UTC 
I really don't know why but this patch does not work.
After applying it:
  ./translate update fr-FR

I don't find the string in the po file.

Marked as Failed QA.
Comment 3 Jonathan Druart 2014-01-15 14:33:35 UTC 
see Owen's comment on bug 11488.
Comment 4 Owen Leonard 2014-01-15 14:44:38 UTC 
I suggest:

var dob = _("Dates of birth should be entered in this format:")+ " '"+[% format %]+"'";

...and note that my comment on Bug 11488 about tab indentation is true of this patch as well.

Ditto on the translation test step.
Comment 5 paxed 2014-01-16 05:49:55 UTC 
(In reply to Owen Leonard from comment #4)
> I suggest:
> 
> var dob = _("Dates of birth should be entered in this format:")+ " '"+[%
> format %]+"'";
> 
> ...and note that my comment on Bug 11488 about tab indentation is true of
> this patch as well.
> 
> Ditto on the translation test step.

Please do not advocate hard-coding the placement of placeholders, it makes translation harder.
Comment 6 Owen Leonard 2014-01-16 13:57:13 UTC 
(In reply to paxed from comment #5)

> Please do not advocate hard-coding the placement of placeholders, it makes
> translation harder.

If you would like to convince me, please don't criticize without providing an explanation. Help me understand rather than just telling me I'm wrong.
Comment 7 Jonathan Druart 2014-01-16 14:02:22 UTC 
Since the strings are currently not translatable, Owen's proposition seems to be a good compromise.
Comment 8 Chris Cormack 2014-01-16 19:37:56 UTC 
This bug is proving to be quite the instruction for the high school students.
Mostly in how not to communicate if you want someone to work on your fix.

Thanks Owen and Jonathan for bringing it back.
Comment 9 Bernardo Gonzalez Kriegel 2014-04-03 18:08:53 UTC 
This problem was fixed in Bug 11753