This discovery is made based off an enhancement being worked on in bug 11343. It has been discovered that when patch 11343 is in place, if I set the new syspref MaxItemsForBatch to 2, and then try to do a batch delete of 3 items, it won't show the 3 items because of the limit, but it will still allow me to delete beyond the limit. I have concern that even without this patch, staff can delete beyond the hard coded 1000 item limit. Can anyone confirm this issue? Christopher
Nicole, Katrin, Could I get your opinion on this one? Bug 8246 has been pushed a couple of weeks ago and there is inconsistency between these 2 bug reports. According to the syspref description it should be considered as a bug. "MaxItemsForBatch: Process up to XXX items in a single modification or deletion batch."
Hi Jonathan, I'd agree that the behaviour described doesn't match the syspref description.
Not sure to know what you should do here. MaxItemsForBatch has been added because "1000" was hardcoded in the code. In the batch item deletion tool it does not block the deletion, but does not display the item info. In the batch item mod tool it completely blocks the modification. This behavior seems to exist previous to bug 11343.
I feel like we should honor the system preference. Wondering: Does it display a warning, that not all information is displayed? (batch item deletion) If we don't honor the pref to its current description, we should rephrase it and also make it clear to the user that not all information is displayed.
(In reply to Katrin Fischer from comment #4) > I feel like we should honor the system preference. > > Wondering: Does it display a warning, that not all information is displayed? > (batch item deletion) > > If we don't honor the pref to its current description, we should rephrase it > and also make it clear to the user that not all information is displayed. I am not sure. In this case, people won't be able to modify more than "MaxItemsForBatch" items. I think the limit has been introduced in order not to freeze the browser if there is too much info to display.
Created attachment 51424 [details] [review] Bug 11490: Add prefs MaxItemsToProcessForBatchMod and MaxItemsToDisplayForBatchDel
Created attachment 51425 [details] [review] Bug 11490: Split MaxItemsForBatch into 2 prefs to clarify things Prior to this patch, a single pref (MaxItemsForBatch) was used to restrict the use of the batch item modification and deletion. On the batch modification tool, the pref is used to limit the number of items a librarian is allowed to modify in a batch, but on the batch deletion tool the pref is used to limit the number of items to display. To clarify things, this patch split the pref into 2 new prefs: MaxItemsToDisplayForBatchDel and MaxItemsToProcessForBatchMod. Later we could add a MaxItemsToProcessForBatchDel if needed. Note that this patch should not introduce any changes in the current behaviors. Test plan: 0/ Do not execute the update DB entry 1/ Set a value != 1000 for MaxItemsForBatch 2/ Execute the update DB entry and confirm that the 2 new prefs are initially set with the value of MaxItemsForBatch and that MaxItemsForBatch has been deleted 3/ Set different values for these 2 prefs (2 and 3 for instance to ease the next steps) 4/ Try to delete less than MaxItemsToDisplayForBatchDel items => You must see the items details 5/ Try to delete more than MaxItemsToDisplayForBatchDel items => You must not see the items details but are allowed to delete them 6/ Try to modify less than MaxItemsToProcessForBatchMod items => You must see the items details 7/ Try to modify more than MaxItemsToProcessForBatchMod items => You must be restricted and not allowed to process
Tested on sandbox, so the updatedatabase is made automatically Both sysprefs are set to 1000 by default 0/ Do not execute the update DB entry 1/ Set a value != 1000 for MaxItemsForBatch 2/ Execute the update DB entry and confirm that the 2 new prefs are initially set with the value of MaxItemsForBatch and that MaxItemsForBatch has been deleted Tested on sandbox, so the updatedatabase is made automatically Both sysprefs are set to 1000 by default MaxItemsForBatch has been deleted 3/ Set different values for these 2 prefs (2 and 3 for instance to ease the next steps) 4/ Try to delete less than MaxItemsToDisplayForBatchDel items => You must see the items details OK 5/ Try to delete more than MaxItemsToDisplayForBatchDel items => You must not see the items details but are allowed to delete them OK 6/ Try to modify less than MaxItemsToProcessForBatchMod items => You must see the items details OK 7/ Try to modify more than MaxItemsToProcessForBatchMod items => You must be restricted and not allowed to process OK
Patch tested with a sandbox, by Laurence Rault <laurence.rault@biblibre.com>
Created attachment 52000 [details] [review] Bug 11490: Add prefs MaxItemsToProcessForBatchMod and MaxItemsToDisplayForBatchDel Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
Created attachment 52001 [details] [review] Bug 11490: Split MaxItemsForBatch into 2 prefs to clarify things Prior to this patch, a single pref (MaxItemsForBatch) was used to restrict the use of the batch item modification and deletion. On the batch modification tool, the pref is used to limit the number of items a librarian is allowed to modify in a batch, but on the batch deletion tool the pref is used to limit the number of items to display. To clarify things, this patch split the pref into 2 new prefs: MaxItemsToDisplayForBatchDel and MaxItemsToProcessForBatchMod. Later we could add a MaxItemsToProcessForBatchDel if needed. Note that this patch should not introduce any changes in the current behaviors. Test plan: 0/ Do not execute the update DB entry 1/ Set a value != 1000 for MaxItemsForBatch 2/ Execute the update DB entry and confirm that the 2 new prefs are initially set with the value of MaxItemsForBatch and that MaxItemsForBatch has been deleted 3/ Set different values for these 2 prefs (2 and 3 for instance to ease the next steps) 4/ Try to delete less than MaxItemsToDisplayForBatchDel items => You must see the items details 5/ Try to delete more than MaxItemsToDisplayForBatchDel items => You must not see the items details but are allowed to delete them 6/ Try to modify less than MaxItemsToProcessForBatchMod items => You must see the items details 7/ Try to modify more than MaxItemsToProcessForBatchMod items => You must be restricted and not allowed to process Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
Created attachment 52496 [details] [review] Bug 11490: Add prefs MaxItemsToProcessForBatchMod and MaxItemsToDisplayForBatchDel Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 52497 [details] [review] Bug 11490: Split MaxItemsForBatch into 2 prefs to clarify things Prior to this patch, a single pref (MaxItemsForBatch) was used to restrict the use of the batch item modification and deletion. On the batch modification tool, the pref is used to limit the number of items a librarian is allowed to modify in a batch, but on the batch deletion tool the pref is used to limit the number of items to display. To clarify things, this patch split the pref into 2 new prefs: MaxItemsToDisplayForBatchDel and MaxItemsToProcessForBatchMod. Later we could add a MaxItemsToProcessForBatchDel if needed. Note that this patch should not introduce any changes in the current behaviors. Test plan: 0/ Do not execute the update DB entry 1/ Set a value != 1000 for MaxItemsForBatch 2/ Execute the update DB entry and confirm that the 2 new prefs are initially set with the value of MaxItemsForBatch and that MaxItemsForBatch has been deleted 3/ Set different values for these 2 prefs (2 and 3 for instance to ease the next steps) 4/ Try to delete less than MaxItemsToDisplayForBatchDel items => You must see the items details 5/ Try to delete more than MaxItemsToDisplayForBatchDel items => You must not see the items details but are allowed to delete them 6/ Try to modify less than MaxItemsToProcessForBatchMod items => You must see the items details 7/ Try to modify more than MaxItemsToProcessForBatchMod items => You must be restricted and not allowed to process Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 16.11, thanks Jonathan!
Pushed in 16.05. Will be in 16.05.03.
Patch pushed to 3.22.x, will be in 3.22.10