Bug 11495 - i18n toolchain misses one instance of text "Select titles to: " in bootstrap
Summary: i18n toolchain misses one instance of text "Select titles to: " in bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Katrin Fischer
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-08 09:34 UTC by paxed
Modified: 2015-06-04 23:30 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11495: Make "Select titles to: " translatable (1.45 KB, patch)
2014-01-11 15:00 UTC, Katrin Fischer
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11495: Make "Select titles to: " translatable (1.55 KB, patch)
2014-01-29 20:39 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11495: Make "Select titles to: " translatable (1.59 KB, patch)
2014-01-31 09:34 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-01-08 09:34:06 UTC
The translation toolchain does not pick up one instance of "Select titles to: " for translation from opac-tmpl/bootstrap/en/modules/opac-results.tt

This means the text is shown in English until you click one of the checkboxes, then the javascript text is applied and it replaces the English text.
Comment 1 Katrin Fischer 2014-01-11 15:00:59 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2014-01-29 20:39:52 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2014-01-31 09:34:23 UTC
Created attachment 24921 [details] [review]
Bug 11495: Make "Select titles to: " translatable

Fixes translation of "Select titles to: " on the Bootstrap
OPAC result page.

Test plan:
- Update one of the po files running:
  perl translate update <langcode>
- Verify that "Select titles to: " is only listed once for
  search-results.tt
Apply patch
- Verify addings titles to lists and cart from the result list
  still works as expected
- Rerun the po file update
- Verify the string is now listed twice for search-results.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Galen Charlton 2014-01-31 15:48:44 UTC
Pushed to master.  Thanks, Katrin!
Comment 5 Frédéric Demians 2014-06-17 09:52:42 UTC
Fridolyn: This patch would deserved to be pushed to 3.14. Thanks.
Comment 6 Fridolin Somers 2014-07-11 06:38:54 UTC
Pushed to 3.14.x, will be in 3.14.09

In fact it looks like a minor bug, not an enhancement.