Bug 11503 - Several typos
Summary: Several typos
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-09 07:49 UTC by paxed
Modified: 2015-06-04 23:23 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11503 - Several typos (31.53 KB, patch)
2014-01-10 16:09 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11503 - Several typos (31.56 KB, patch)
2014-01-13 06:25 UTC, Mark Tompsett
Details | Diff | Splinter Review
[PASSED QA] Bug 11503 - Several typos (31.90 KB, patch)
2014-01-13 19:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 11503 [Follow-up] Several typos (1.28 KB, patch)
2014-01-14 13:53 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11503 [Follow-up] Several typos (1.31 KB, patch)
2014-01-14 14:34 UTC, Mark Tompsett
Details | Diff | Splinter Review
[PASSED QA] Bug 11503 [Follow-up] Several typos (1.38 KB, patch)
2014-01-14 19:35 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-01-09 07:49:27 UTC
"Acquistions" in intranet-tmpl/prog/en/modules/help/reports/guided_reports.tt

"secton" in intranet-tmpl/prog/en/modules/help/members/member-flags.tt

"Van der Griten" (should be Van der Grinten) in intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_120.tt

"exisiting" in intranet-tmpl/prog/en/modules/authorities/authorities.tt and intranet-tmpl/prog/en/modules/help/serials/subscription-frequencies.tt

"techniqu" in intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_121a.tt

"ressource" in intranet-tmpl/prog/en/includes/subtypes_unimarc.inc, opac-tmpl/prog/en/includes/subtypes_unimarc.inc and opac-tmpl/bootstrap/en/includes/subtypes_unimarc.inc

"cliam" in intranet-tmpl/prog/en/modules/help/acqui/lateorders.tt

"possesion" in intranet-tmpl/prog/en/modules/reserve/request.tt
Comment 1 Owen Leonard 2014-01-10 16:09:56 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2014-01-11 05:04:49 UTC
Comment on attachment 24161 [details] [review]
Bug 11503 - Several typos

Review of attachment 24161 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/includes/subtypes_unimarc.inc
@@ +29,4 @@
>              <option value="ff8-23:h">hand-written</option>
>              <option value="ff8-23:i">multimedia</option>
>              <option value="ff8-23:j">mini-print</option>
> +            <option value="ff8-23:s">electronic resource</option>

Removed extra S. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
@@ +158,4 @@
>  
>                  <form action="authorities.pl" method="get">
>                      <input type="hidden" name="authid" value="[% duplicateauthid %]" />
> +                    <input type="submit" class="edit" value="Yes: Edit existing authority" />

Removed excess i. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_121a.tt
@@ +48,4 @@
>  				<option value="c">by computer</option>
>  			[% END %]
>  			[% IF ( f2d ) %]
> +                <option value="d" selected="selected">by active remote sensing technique</option>

Added missing e. Check.

@@ +52,2 @@
>  			[% ELSE %]
> +                <option value="d">by active remote sensing technique</option>

Added missing e. Check.

@@ +226,4 @@
>  				<option value="u">unknown</option>
>  			[% END %]
>  			[% IF ( f5y ) %]
> +                <option value="y" selected="selected">the cartographic item is not a final product</option>

Added missing t. Check.

@@ +230,2 @@
>  			[% ELSE %]
> +                <option value="y">the cartographic item is not a final product</option>

Added missing t. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/about.tt
@@ +10,4 @@
>  
>  <h2>Perl modules</h2>
>  
> +<p>This tab lists all the dependent Perl modules for Koha and whether or not you have them installed, and the version number. If you are reporting an issue, the developer may ask what is the state of the Perl modules you have installed.</p>

Changes a to e for dependent. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/basket.tt
@@ +101,4 @@
>  
>  <p>Clicking the 'Uncertain Prices' button will call up a list of items with uncertain prices to quick editing.</p>
>  
> +<p style="color: #ff0000">Important: The Uncertain Prices page is independent of the basket. It is linked to the vendor so you will see all items on order with uncertain prices for that vendor.</p>

Changes e to o for vendor. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/lateorders.tt
@@ +14,4 @@
>  
>  <p><strong>Note:</strong> The Estimated Delivery Date is based on the Delivery time value entered on the vendor record.</p>
>  
> +<p>There is a default acquisitions claim letter. If you would rather use a different one, you can create that in the notices module and choose it from the menu above the list of late items.</p>

Corrects spelling of claim. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/auth_subfields_structure.tt
@@ +20,4 @@
>  <ul>
>    <li>'Text for librarian' is what appears before the subfield in the librarian interface.</li>
>    <li>'Text for OPAC' is what appears before the field in the OPAC.If left empty, the text for librarian is used instead</li>
> +    <li>If 'Repeatable' is checked, the field  will have a plus sign next to it in the MARC cataloging module which allows you to add multiples of that tag.</li>

Corrected monologue to module. -- missed double space, but HTML will cover that. Okay.

@@ +50,4 @@
>  <ul>
>      <li>(! means 'not visible' or in the case of collapsed 'not collapsed')</li>
>      <li>If 'Is a url' is checked, the subfield is a url and can be clicked</li>
> +    <li>'Authorized Value' allows the librarian to select an authorized value list from which catalogers must choose an option.</li>

Changed cataloguers to catalogers. FEEDBACK DESIRED.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/authorised_values.tt
@@ +33,4 @@
>      <li>'MANUAL_INV' includes values for manual invoicing.</li>
>      <li>'NOT_LOAN' is used to list reasons why a title is not for loan.</li>
>      <li>'PROC' is for the location to be used for NewItemsDefaultLocation (change description as desired), also the location expected by InProcessingToShelvingCart.</li>
> +    <li>'REPORT_GROUP' provides a way to sort and filter your reports, the default values in this category include the Koha modules (Accounts, Acquisitions, Catalog, Circulation, Patrons)</li>

Corrected spelling of Acquisitions. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/item_circulation_alerts.tt
@@ +16,4 @@
>  	<li>To set preferences for all libraries, keep the menu set to 'Default'</li>
>  </ul>
>  </li>
> +    <li>By default all item types and all patrons are notified of check ins and check outs. To change this, click on the item/patron type combination that you would like to stop notices for.</li>

Changed combo to combination. Good idea. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/preferences.tt
@@ +16,4 @@
>  
>  <ul>
>      <li><strong>Acquisitions:</strong> holds preferences related to acquisitions such as handling patron suggestions and local taxes.</li>
> +    <li><strong>Administration:</strong> holds administrative preferences such as admin email address, sessions and timeout.</li>

Added missing e in timeout. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/smart-rules.tt
@@ +23,4 @@
>  
>  <h4>Default Circulation Rules</h4>
>  
> +<p>Using the issuing rules matrix you can define rules that depend on patron/item type combinations. To set your rules, choose a library from the pull down (or 'all libraries' if you want to apply these rules to all libraries)</p>

Corrected 'typecombos' to 'type combinations'. Check.

@@ +33,4 @@
>  	<li>Limit the number of items a patron can have checked out at the same time by entering a number in the 'Current Checkouts Allowed' field</li>
>      <li>Define the period of time an item can be checked out to a patron by entering the number of units (days or hours) in the 'Loan Period' box.</li>
>      <li>Choose which unit of time, Days or Hours, that the loan period and fines will be calculate in</li>
> +    <li>You can also define a hard due date for a specific patron category and item type. A hard due date ignores your usual circulation rules and makes it so that all items of the type defined are due on, before or after the date you specify.</li>

Adding missing space between all and items. Check.

@@ +57,4 @@
>  </li>
>      <li>Next decide if the patron can renew this item type and if so, enter how many times they can renew it in the 'Renewals Allowed' box</li>
>      <li>If the patron can place holds on this item type, enter the total numbers of items (of this type) that can be put on hold in the 'Holds Allowed' field</li>
> +    <li>Finally, if you charge a rental fee for the item type and want to give a specific patron type a discount on that fee, enter the percentage discount (without the % symbol) in the 'Rental Discount' field</li>

Added missing space between fee and for. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/mainpage.tt
@@ +11,4 @@
>  <li><a href="http://koha-community.org/documentation/">Read Koha documentation</a></li>
>  <li><a href="http://wiki.koha-community.org">Read/Write to the Koha wiki</a></li>
>  <li><a href="http://koha-community.org/support/koha-mailing-lists/">Read and contribute to discussions</a></li>
> +<li><a href="http://bugs.koha-community.org">Report Koha bugs</a></li>

Capitalized Koha. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/members/member-flags.tt
@@ +45,4 @@
>  	<li>parameters
>  <ul>
>  	<li>Manage Koha system settings (Administration panel)</li>
> +    <li>This section can be expanded</li>

Corrected spelling of section. Check.

@@ +71,4 @@
>  </li>
>  	<li>editcatalogue
>  <ul>
> +    <li>Edit Catalog (Modify bibliographic/holdings data)</li>

Added missing l in holdings. Check.

@@ +88,4 @@
>  </li>
>  	<li>management
>  <ul>
> +    <li>Set library management parameters (deprecated)

Corrected spelling of parameters. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/plugins/plugins-home.tt
@@ +2,4 @@
>  
>  <h1>Plugins</h1>
>  
> +<p>Koha's Plugin System allows for you to add additional tools and reports to Koha that are specific to your library.  Plugins are installed by uploading KPZ ( Koha Plugin Zip ) packages. A KPZ file is just a zip file containing the perl files, template files, and any other files necessary to make the plugin work.</p>

Removed excess c from necessary. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/plugins/plugins-upload.tt
@@ +2,4 @@
>  
>  <h1>Upload Koha plugin</h1>
>  
> +<p>Koha's plugin system allows for you to add additional tools and reports to Koha that are specific to your library.  Plugins are installed by uploading KPZ ( Koha Plugin Zip ) packages. A KPZ file is just a zip file containing the perl files, template files, and any other files necessary to make the plugin work.</p>

Corrected the spelling of necessary. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/reports/guided_reports.tt
@@ +84,4 @@
>  
>  <p>Reports can also be added by duplicating an existing report. Visit the 'Saved reports' page to see all of the reports listed on your system.</p>
>  
> +<p>To the right of every report there is an 'Actions' pull down. Clicking that and choose 'Duplicate' to use an existing report as the basis for your new report. That will populate the new report form with the existing SQL for easy editing and resaving.</p>

Added missing g to Clicking. Check.

@@ +167,4 @@
>  	<li>1 = Circulation</li>
>  	<li>2 = Catalog</li>
>  	<li>3 = Patrons</li>
> +    <li>4 = Acquisitions</li>

Corrected spelling of Acquisitions. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/reserve/request.tt
@@ +28,4 @@
>  </li>
>  	<li>If the patron has specified that they don't want the item after a certain date, or if you have limits on hold lengths, you can enter an expiration date for the hold in the 'Hold expires on date'
>  <ul>
> +    <li>To have expired holds cancelled automatically you will need to have the Expired Holds cron job set to run on a regular basis.</li>

Corrected spelling of cancelled. Is this another American vs. non-American English issue?

@@ +40,4 @@
>  
>  <h2>Managing Holds</h2>
>  
> +<p>Holds can be altered and cancelled from the Holds tab found on the left of the bibliographic record.</p>

Corrected spelling of cancelled. Same question.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/serials/serials-edit.tt
@@ +1,3 @@
>  [% INCLUDE 'help-top.inc' %]
>  
> +<h1>Receiving Serials</h1>

Corrected spelling of Receiving. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/serials/subscription-detail.tt
@@ +4,4 @@
>  
>  <p>This page shows you all of the information about your subscription including issue history.</p>
>  
> +<p>From here you can edit your subscription, renew it and/or receive issues.</p>

Corrected spelling of receive. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/serials/subscription-frequencies.tt
@@ +4,4 @@
>  
>  <p>Koha keeps a record of publication frequencies for easy management and duplication.</p>
>  
> +<p>From this page you can view all of the existing frequencies in your system and create new ones.</p>

Removed extra i from existing. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/holidays.tt
@@ +10,4 @@
>  	<li>Choose the method for calculating due date - either include days the library is closed in the calculation or don't include them.</li>
>  </ul>
>  </li>
> +    <li><em>Get there:</em> More &gt; Administration &gt; Global System Preferences &gt; Circulation &gt; finesCalendar

Is that supposed to be finesCalendar or Fines Calendar?

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/marc_modification_templates.tt
@@ +4,4 @@
>  
>  <p>The MARC Modification Templates system gives Koha users the power to make alterations to MARC records automatically while staging MARC records for import.</p>
>  
> +<p>This tool is useful for altering MARC records from various vendors/sources work with your MARC framework. The system essentially allows one to create a basic script using actions to Copy, Move, Add, Update and Delete fields.</p>

Corrected spelling of vendors. Check.

@@ +18,4 @@
>     <li>Click 'Add action'</li>
>  </ul>
>  
> +<p>Each action can also have an optional condition to check the value or existence of another field. For example you might want to add the call number to the item record if it's not already there.</p>

Corrected spelling of existence. What about a comma after For example?

@@ +22,4 @@
>  
>  <ul>
>        <li>Choose 'Copy'</li>
> + <li>Decide if you want to copy the first occurrence or all occurrences of the field</li>

Corrected occurance to occurrence. Check.

@@ +36,4 @@
>  
>  <ul>
>    <li>Choose 'Copy'</li>
> + <li>Decide if you want to copy the first occurrence or all occurrences of the field</li>

Corrected occurance to occurrence. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/quotes-upload.tt
@@ +26,4 @@
>      <li><b>Delete Quote(s)</b></li>
>      <ol>
>          <li>This option allows for the deletion of one or more quotes at a time.</li>
> +        <li>Select the quote(s) you desire to delete by clicking on the corresponding quote id.</li>

Corrected spelling of corresponding. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/quotes.tt
@@ +26,4 @@
>      <li><b>Delete Quote(s)</b></li>
>      <ol>
>          <li>This option allows for the deletion of one or more quotes at a time.</li>
> +        <li>Select the quote(s) you desire to delete by clicking on the corresponding quote id.</li>

Corrected spelling of corresponding. Check.

::: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
@@ +246,4 @@
>            <li> <strong>No copies are available</strong> to be placed on hold</li>
>          [% END %]
>          [% IF ( alreadypossession ) %]
> +          <li> <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a> <strong>is already in possession</strong> of one item</li>

Added missing s to possession. Check.
Comment 3 Mark Tompsett 2014-01-11 05:08:03 UTC
Take note of the one's I didn't put "Check" or "Okay" on. I did suggest another edit as well. There were American vs. non-American English questions in my mind. What is it supposed to be?
Comment 4 Mark Tompsett 2014-01-13 06:06:44 UTC
Assuming cataloguer should become cataloger and canceled should become cancelled, I have no problem. I confirmed the variable is finesCalendar. Those changes being more of an American spelling, which I suspect en is supposed to be. I'm going to sign this off.
Comment 5 Mark Tompsett 2014-01-13 06:25:44 UTC Comment hidden (obsolete)
Comment 6 Bob Birchall 2014-01-13 06:39:18 UTC
(In reply to M. Tompsett from comment #3)
> Take note of the one's I didn't put "Check" or "Okay" on. I did suggest
> another edit as well. There were American vs. non-American English questions
> in my mind. What is it supposed to be?

US usage is 'catalogers'; usage in other english speaking countries is 'cataloguers' - should prolly be left with US spelling and changed in translations.

'Cancelled' seems to be used everywhere except in US, but even there it may not be consistent.  I saw 'canceled' used by the NY Times and Seattle Post however Avis website has 'cancelled'.  I saw other .com websites with 'cancelled' but maybe not all are US sites?

'finesCalendar' is a reference to the sys pref, not to the object of the sys pref, and so is correct, imo.

I think a comma after 'For example' is not necessary, but would not be incorrect either.

I hope this helps.
Comment 7 Katrin Fischer 2014-01-13 18:46:03 UTC
Some of the typos are in the help files - adding Nicole as she copies the texts from the manual.
Comment 8 Katrin Fischer 2014-01-13 19:30:35 UTC
Created attachment 24237 [details] [review]
[PASSED QA] Bug 11503 - Several typos

This patch corrects several typos: Some reported in Bug 11503, others
found during a systematic spell check of the help files.

To test, examine the changes and confirm that the spelling changes are
correct.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 9 Galen Charlton 2014-01-13 22:02:58 UTC
Pushed to master.  Thanks, Owen!
Comment 10 paxed 2014-01-14 06:13:29 UTC
I didn't see the "Van der Griten" fixed in there?
Comment 11 Owen Leonard 2014-01-14 13:53:21 UTC Comment hidden (obsolete)
Comment 12 Mark Tompsett 2014-01-14 14:33:16 UTC
Comment on attachment 24237 [details] [review]
[PASSED QA] Bug 11503 - Several typos

This is the main patch which was already pushed to master.
Comment 13 Mark Tompsett 2014-01-14 14:34:40 UTC Comment hidden (obsolete)
Comment 14 Katrin Fischer 2014-01-14 19:35:36 UTC
Created attachment 24295 [details] [review]
[PASSED QA] Bug 11503 [Follow-up] Several typos

There is still a typo left to fix which I didn't catch because I was
doing a spell-check and didn't double-check the bug report:

Van der Griten -> Van der Grinten

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 15 Galen Charlton 2014-01-14 20:12:30 UTC
I've pushed the follow-up to master.  Thanks, Owen!
Comment 16 Nicole C. Engard 2014-01-21 17:40:37 UTC
Not all of those typos were in the manual - but I have fixed the ones that were.

Nicole
Comment 17 Fridolin Somers 2014-03-07 08:07:03 UTC
Patches pushed to 3.14.x, will be in 3.14.5