Bug 11504 - Untranslatable "Item Type" or "Collection Code" in branch transfer limits
Summary: Untranslatable "Item Type" or "Collection Code" in branch transfer limits
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-09 09:05 UTC by paxed
Modified: 2015-06-04 23:32 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11504: Untranslatable "Item Type" or "Collection Code" in branch transfer limits (2.65 KB, patch)
2014-08-14 23:00 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 11504: Untranslatable "Item Type" or "Collection Code" in branch transfer limits (2.73 KB, patch)
2014-08-15 02:06 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 11504: Untranslatable "Item Type" or "Collection Code" in branch transfer limits (2.93 KB, patch)
2014-08-15 14:15 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-01-09 09:05:28 UTC
The string "Item Type" or "Collection Code" shows up in branch transfer limits, eg. in the text "For all Item Types:", and does not come via the i18n toolchain.

The text is hard-coded in admin/branch_transfer_limits.pl
Comment 1 Bernardo Gonzalez Kriegel 2014-08-14 23:00:23 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-08-14 23:02:54 UTC
Sorry, apply the patch and then follow test plan.
Comment 3 Chris Cormack 2014-08-15 02:06:02 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-08-15 14:15:06 UTC
Created attachment 30840 [details] [review]
[PASSED QA] Bug 11504: Untranslatable "Item Type" or "Collection Code" in branch transfer limits

This patch makes reported strings translatable.

To test:
1. Go to Administration > Library transfer limits

2. Depending on the value of BranchTransferLimitsType
your may see in a box:
a) For *all* Collection codes:
b) For *all* Item types:

change system preference to show both values

3. Update translation files for your preferred language
check new entry
msgid "%sCollection codes%sItem types%s: "

Not pretty but can be translated.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I have to confess that I lower cased the collections and item
types as they appear in a sentence.
No other changes made and this works nicely.
Comment 5 Tomás Cohen Arazi 2014-08-15 18:45:25 UTC
Patch pushed to master.

Thanks Bernardo!