Bug 11505 - Untranslatable table headers in Label batch manager
Summary: Untranslatable table headers in Label batch manager
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-09 09:45 UTC by paxed
Modified: 2015-06-04 23:23 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11505 - Untranslatable table headers in Label batch manager (2.82 KB, patch)
2014-01-10 21:03 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11505 - Untranslatable table headers in Label batch manager (2.84 KB, patch)
2014-01-11 02:49 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 11505 - Untranslatable table headers in Label batch manager (3.01 KB, patch)
2014-01-11 20:41 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-01-09 09:45:37 UTC
In Label Batch manager, after adding the items to the batch, you're presented with a table showing information about the items. The table column headers are in English, and cannot be translated.

The texts are hard-coded in $display_columns in labels/label-edit-batch.pl
Comment 1 Owen Leonard 2014-01-10 21:03:47 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-01-11 02:49:25 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-01-11 20:41:16 UTC
Created attachment 24200 [details] [review]
[PASSED QA] Bug 11505 - Untranslatable table headers in Label batch manager

The label batch manager script hard-codes the table header cell labels
in order to pass them to an HTML-building function. This obviously isn't
the best solution for internationalization, but picking the whole scheme
apart would be very complicated.

Instead this patch uses a SWITCH statement to check for each possible
case and outputs the correct translatable string for each.

To test, apply the patch and run "perl translate update" for any
translation. Check the revised po file and confirm that the new strings
are present. View the label batch edit page and confirm that the table
headings look correct: Tools -> Labels -> Manage batches -> Edit batch.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes all tests.
Similar fixes are probably needed for other pages of the labels
modules.
Comment 4 Galen Charlton 2014-01-13 22:01:04 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-03-07 08:20:57 UTC
Patch pushed to 3.14.x, will be in 3.14.5
Comment 6 Chris Cormack 2014-03-24 04:38:33 UTC
Pushed to 3.12.x will be in 3.12.12