The usage information is not helpful as-is. It can be refactored a bit.
Created attachment 24090 [details] [review] Bug 11509: koha-create should print better usage information This patch makes koha-create print better and more descriptive usage information. Also adds the --help and -h switches. Regards To+ Sponsored-by: Universidad Nacional de Cordoba
Created attachment 24098 [details] [review] Bug 11509: koha-create should print better usage information This patch makes koha-create print better and more descriptive usage information. Also adds the --help and -h switches. Regards To+ Sponsored-by: Universidad Nacional de Cordoba
Created attachment 24205 [details] [review] Bug 11509: koha-create should print better usage information This patch makes koha-create print better and more descriptive usage information. Also adds the --help and -h switches. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 24239 [details] [review] [PASSED QA] Bug 11509: koha-create should print better usage information This patch makes koha-create print better and more descriptive usage information. Also adds the --help and -h switches. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Removed trailing " from: $scriptname [db usage mode] [options] instancename"
Created attachment 24240 [details] [review] [PASSED QA] Bug 11509: koha-create should print better usage information This patch makes koha-create print better and more descriptive usage information. Also adds the --help and -h switches. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Removed trailing " from: $scriptname [db usage mode] [options] instancename"
Pushed to master. Thanks, Tomás!
Patch pushed to 3.14.x, will be in 3.14.4.
Created attachment 25173 [details] [review] Bug 11509: (trivial rmaint followup) wrong parameter count While adding the --help and -h switches I forgot to change to arguments count validation so that one can actually use those parameters (i.e. koha-create should accept being invoked with only one parameter). This patch just changes the minimum parateres required from 2 to 1. To reproduce: - Run 'koha-create --help' from master => Usage information is printed BUT ALSO an "Error: wrong parameters" message - Apply the patch and - Run 'koha-create --help' => Usage informatio it printed and no error message. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
I've pushed the follow-up to master. Thanks, Tomas!
"wrong parameter count" patch pushed to 3.14.x, will be in 3.14.5