Bug 11513 - Warnings in Patron categories
Summary: Warnings in Patron categories
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Mark Tompsett
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-10 05:12 UTC by Mark Tompsett
Modified: 2015-06-04 23:30 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11513 - Warnings in Patron categories (2.39 KB, patch)
2014-01-10 05:13 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11513 - Warnings in Patron categories (4.80 KB, patch)
2014-01-10 06:28 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11513 - Warnings in Patron categories (6.80 KB, patch)
2014-01-10 16:42 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11513 - Warnings in Patron categories (6.69 KB, patch)
2014-01-10 17:39 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11513 - Warnings in Patron categories (6.75 KB, patch)
2014-01-17 01:07 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11513 - perltidy, fix license, a couple other eyeball tweaks (26.70 KB, patch)
2014-01-17 02:07 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11513 - perltidy, fix license, a couple other eyeball tweaks (28.00 KB, patch)
2014-01-17 02:13 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11513 - perltidy, fix license, a couple other eyeball tweaks (27.99 KB, patch)
2014-01-17 02:17 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11513 - perltidy, fix license, a couple other eyeball tweaks (27.57 KB, patch)
2014-01-17 02:26 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11513 - perltidy, fix license, a couple other eyeball tweaks (27.54 KB, patch)
2014-01-17 02:34 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11513 - Warnings in Patron categories (8.39 KB, patch)
2014-01-17 02:58 UTC, Mark Tompsett
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11513 - Warnings in Patron categories (8.56 KB, patch)
2014-01-29 15:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11513 - Warnings in Patron categories (8.72 KB, patch)
2014-01-31 10:58 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Tompsett 2014-01-10 05:12:16 UTC
Floody warnings were discovered during testing Koha. To reproduce what was discovered:
1) Log in to staff client
2) Click 'Administration'
3) Click 'Patron categories'
4) Review error log, several warnings.
Comment 1 Mark Tompsett 2014-01-10 05:13:56 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2014-01-10 06:28:06 UTC Comment hidden (obsolete)
Comment 3 Mark Tompsett 2014-01-10 16:42:36 UTC Comment hidden (obsolete)
Comment 4 Mark Tompsett 2014-01-10 17:39:45 UTC Comment hidden (obsolete)
Comment 5 Merllissia Manueli 2014-01-16 20:12:18 UTC
Still receiving these errors:

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl
Comment 6 Merllissia Manueli 2014-01-16 20:14:24 UTC
Still receiving these errors:

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl

[Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl
Comment 7 Mark Tompsett 2014-01-17 01:05:04 UTC
I can't verify the problem, but I can see how it happens. The revised patch should solve this.
Comment 8 Mark Tompsett 2014-01-17 01:07:01 UTC Comment hidden (obsolete)
Comment 9 Mark Tompsett 2014-01-17 02:07:09 UTC Comment hidden (obsolete)
Comment 10 Mark Tompsett 2014-01-17 02:13:30 UTC Comment hidden (obsolete)
Comment 11 Mark Tompsett 2014-01-17 02:17:19 UTC Comment hidden (obsolete)
Comment 12 Mark Tompsett 2014-01-17 02:26:44 UTC Comment hidden (obsolete)
Comment 13 Mark Tompsett 2014-01-17 02:34:01 UTC Comment hidden (obsolete)
Comment 14 Mark Tompsett 2014-01-17 02:41:30 UTC
Comment on attachment 24480 [details] [review]
Bug 11513 - perltidy, fix license, a couple other eyeball tweaks

Forget reindenting, fixing licensing, etc. Let's keep this simple.
Comment 15 Mark Tompsett 2014-01-17 02:58:30 UTC Comment hidden (obsolete)
Comment 16 Owen Leonard 2014-01-29 15:43:12 UTC Comment hidden (obsolete)
Comment 17 Marcel de Rooy 2014-01-31 10:32:51 UTC
Enrolment is BE,  Enrollment is AE 
But categorie sounds Dutch to me :)

Just referring to script and column names here..
Comment 18 Marcel de Rooy 2014-01-31 10:58:00 UTC
Created attachment 24931 [details] [review]
Bug 11513 - Warnings in Patron categories

Just going to the patron categories page triggered errors.
Running through all the plain options also triggered other
warnings. This fix silences them.

Discovered tabs I had not corrected by running qa test tool.

Some errors which I could not trigger were also fixed, such
as line 248 shown by Merllissia Manueli.

TEST PLAN
---------
 1) Log in to staff client
 2) Click 'Administration'
 3) Click 'Patron categories'
 4) Click '+ New category'
 5) Enter a dummy category and click 'Save'
 6) Click 'Edit' for the dummy category.
 7) Change a value and click 'Save'
 8) Click 'Delete' for the dummy category.
 9) Confirm to delete.
10) Review error log, several new warnings
11) Apply patch
12) Run the koha qa test tool.
13) Click 'Home'
14) Click 'Administration'
15) Click 'Patron categories'
16) Click '+ New category'
17) Enter a dummy category and click 'Save'
18) Click 'Edit' for the dummy category.
19) Change a value and click 'Save'
20) Click 'Delete' for the dummy category.
21) Confirm to delete.
22) Review error log, no new warnings

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Followed test plan, saw no errors in the log after applying the patch.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested various dates and enrollment periods with different settings of
dateformat pref. Works as advertised. No warnings.
Comment 19 Marcel de Rooy 2014-01-31 11:00:35 UTC
Even the split on an empty string is thoroughly tested :)
(I would have assumed that I got back the empty string, but perl keeps surprising..)
Code looks good to me. Passed QA
Comment 20 Galen Charlton 2014-01-31 16:24:02 UTC
Pushed to master, along with a follow-up that ensures that KohaDates is used for all occurrences of the enrollment end date.  Thanks, Mark!
Comment 21 Fridolin Somers 2014-04-23 17:35:00 UTC
Patches pushed to 3.14.x, will be in 3.14.06
Comment 22 Kyle M Hall 2014-06-06 13:48:36 UTC
Pushed to 3.12.x will be in 3.12.13