Hard-coded, untranslatable text in acquisitions: acqui/basket.pl: $line{rrpgste} .= ' (Uncertain)'; acqui/invoice.pl: $line{rrp} .= ' (Uncertain)';
Also hardcoded "Deleted bibliographic notice, can't find title." in acqui/basket.pl
I will try to provide a patch when bug 13323 will be pushed.
Still valid?
Hm, needs testing?
acqui/basket.pl: $line{rrp_tax_excluded} .= ' (Uncertain)'; acqui/invoice.pl: $line{rrp} .= ' (Uncertain)';
Still an issue.
Created attachment 91409 [details] [review] Bug 11514: Untranslatable "Uncertain" text in acq This patch modifies two pages so that the "Uncertain price" information is shown by the template rather than the Perl script, making the text translatable. To test, apply the patch and go to Acquisitions. - Locate or create an order in a basket which has an uncertain price. - When viewing the contents of that basket the order which was marked as having an uncertain price should be labeled "Uncertain." - The same should be true for the invoice page. If you don't have an existing invoice with an "uncertain" order, - Go to "Receive shipments" for the vendor your "uncertain" order is with. - Create a new invoice. - Receive one or more orders which has an uncertain price. - Press the "finish receiving" button. - In the "Invoice details" section of the invoice page you should see the "Uncertain" label on the correct order.
Created attachment 93323 [details] [review] Bug 11514: Untranslatable "Uncertain" text in acq This patch modifies two pages so that the "Uncertain price" information is shown by the template rather than the Perl script, making the text translatable. To test, apply the patch and go to Acquisitions. - Locate or create an order in a basket which has an uncertain price. - When viewing the contents of that basket the order which was marked as having an uncertain price should be labeled "Uncertain." - The same should be true for the invoice page. If you don't have an existing invoice with an "uncertain" order, - Go to "Receive shipments" for the vendor your "uncertain" order is with. - Create a new invoice. - Receive one or more orders which has an uncertain price. - Press the "finish receiving" button. - In the "Invoice details" section of the invoice page you should see the "Uncertain" label on the correct order. Signed-off-by: Christophe Croullebois <christophe.croullebois@biblibre.com>
I can't make the 'Uncertain' text appear before these patches, can you explain a little more?
While I think the patch doesn't break anything, it doesn't make sense to me. 1) Uncertain doesn't show on the basket page now, but I am almost certain that it used to. So the patch might be seen as a bug fix. 2) For invoices: A basket that has an uncertain price in it cannot be closed. Order from an unclosed basket cannot be added to invoices - so I am not sure how to test the second change. Back to Christophe for help with the test plan - or maybe someone else can help?
I can confirm that: 1) It's a bug fix for the existing behavior: "(Uncertain)" is not longer displayed, because of the use of the Price plugin. 2) We cannot test the second part of the patch. Even if it cannot hurt it may make more sense to remove the code in the controller and don't touch the template file.
(In reply to Jonathan Druart from comment #11) > I can confirm that: > > 1) It's a bug fix for the existing behavior: "(Uncertain)" is not longer > displayed, because of the use of the Price plugin. > > 2) We cannot test the second part of the patch. Even if it cannot hurt it > may make more sense to remove the code in the controller and don't touch the > template file. Thx, Jonathan!
Owen, you closed this bug but I think it is still useful. Even if it needs a small adjustment. See comment 11 > 1) It's a bug fix for the existing behavior: "(Uncertain)" is not longer displayed, because of the use of the Price plugin.
(In reply to Jonathan Druart from comment #13) > Owen, you closed this bug but I think it is still useful. Even if it needs a > small adjustment. The bug refers to a translation issue and the translation issue is now invalid. If someone else want to continue to work on it I suggest at least renaming the report.
Created attachment 95043 [details] [review] Bug 11514: Untranslatable "Uncertain" text in acq This patch modifies two pages so that the "Uncertain price" information is shown by the template rather than the Perl script, making the text translatable. To test, apply the patch and go to Acquisitions. - Locate or create an order in a basket which has an uncertain price. - When viewing the contents of that basket the order which was marked as having an uncertain price should be labeled "Uncertain." - The same should be true for the invoice page. If you don't have an existing invoice with an "uncertain" order, - Go to "Receive shipments" for the vendor your "uncertain" order is with. - Create a new invoice. - Receive one or more orders which has an uncertain price. - Press the "finish receiving" button. - In the "Invoice details" section of the invoice page you should see the "Uncertain" label on the correct order. Signed-off-by: Christophe Croullebois <christophe.croullebois@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> For the invoice view: close, receive, reopen, mark prices uncertain, go to the invoice page (not sure it's expected however)
Nice work! Pushed to master for 19.11.00