Bug 11517 - MARC21slim2intranetResults.xsl has swapped braille and combination
Summary: MARC21slim2intranetResults.xsl has swapped braille and combination
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-10 12:25 UTC by paxed
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11517: Braille and combination swapped in XSLT result lists (2.44 KB, patch)
2014-09-01 21:46 UTC, Katrin Fischer
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11517: Braille and combination swapped in XSLT result lists (2.58 KB, patch)
2014-10-28 21:10 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 11517: Braille and combination swapped in XSLT result lists (2.63 KB, patch)
2014-10-30 16:47 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-01-10 12:25:01 UTC
<xsl:if test="marc:controlfield[@tag=007][substring(text(),1,1)='f'][substring(text(),2,1)='c']">
                braille
            </xsl:if>
            <xsl:if test="marc:controlfield[@tag=007][substring(text(),1,1)='f'][substring(text(),2,1)='b']">
                combination
            </xsl:if>


But MARC21 format says:
00 - Category of material
f - Tactile material

01 - Specific material designation
b - Braille
c - Combination
Comment 1 Katrin Fischer 2014-09-01 21:46:49 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-10-28 21:10:16 UTC Comment hidden (obsolete)
Comment 3 Brendan Gallagher 2014-10-30 16:47:25 UTC
Created attachment 32988 [details] [review]
Bug 11517: Braille and combination swapped in XSLT result lists

http://www.loc.gov/marc/bibliographic/bd007f.html

- Catalog a record:
  * 007 - choose 'Tactile material'
  * Pos. 1 - choose b = Braille or C = combination
  * Reindex!
  * Verify the result list shows the format correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Problem exist, fixed with this patch.
No koha-qa errors

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2014-10-31 17:53:54 UTC
Patch pushed to master.

Thanks Katrin!