If you are using the transport cost matrix, and you create a new library, you cannot edit the fields for this library! To reproduce: 1) Enable the transport cost matrix 2) Set some transport cost values in the matrix 3) Save the matrix 4) Create a new library 5) View the transport cost matrix again 6) Note the uneditable fields for the new branch Cause: The transport cost matrix assumes either every library is in the transport_matrix table, or that no libraries are in it.
Created attachment 24229 [details] [review] Bug 11531 - Cannot add new libraries to the transport cost if previously used. If you are using the transport cost matrix, and you create a new library, you cannot edit the fields for this library! Test Plan: 1) Enable the transport cost matrix 2) Set some transport cost values in the matrix 3) Save the matrix 4) Create a new library 5) View the transport cost matrix again 6) Note the uneditable fields for the new branch 7) Apply this patch 8) View the transport cost matrix again 9) Note you can now edit the fields for the new branch
Created attachment 25773 [details] [review] Bug 11531 - Cannot add new libraries to the transport cost if previously used. If you are using the transport cost matrix, and you create a new library, you cannot edit the fields for this library! Test Plan: 1) Enable the transport cost matrix 2) Set some transport cost values in the matrix 3) Save the matrix 4) Create a new library 5) View the transport cost matrix again 6) Note the uneditable fields for the new branch 7) Apply this patch 8) View the transport cost matrix again 9) Note you can now edit the fields for the new branch Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 26207 [details] [review] [PASSED QA] Bug 11531 - Cannot add new libraries to the transport cost if previously used. If you are using the transport cost matrix, and you create a new library, you cannot edit the fields for this library! Test Plan: 1) Enable the transport cost matrix 2) Set some transport cost values in the matrix 3) Save the matrix 4) Create a new library 5) View the transport cost matrix again 6) Note the uneditable fields for the new branch 7) Apply this patch 8) View the transport cost matrix again 9) Note you can now edit the fields for the new branch Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script.
Pushed to master. Thanks, Kyle!
Pushed to 3.14.x, will be in 3.14.08
Pushed to 3.12.x, will be in 3.12.13