Bug 11537 - Increasing test coverage for C4::Log
Summary: Increasing test coverage for C4::Log
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Chris Cormack
QA Contact: Galen Charlton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-13 22:51 UTC by Merllissia Manueli
Modified: 2014-12-07 20:07 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (766 bytes, patch)
2014-01-13 22:59 UTC, AlexHorsman
Details | Diff | Splinter Review
bug 11537: Increasing test coverage for C4::Log (857 bytes, patch)
2014-01-13 23:02 UTC, Liz Rea
Details | Diff | Splinter Review
bug 11537: Increasing test coverage for C4::Log (1.03 KB, patch)
2014-01-13 23:12 UTC, David Cook
Details | Diff | Splinter Review
bug 11537: Increasing test coverage for C4::Log (1.10 KB, patch)
2014-01-13 23:16 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 11537: Increasing test coverage for C4::Log (1.27 KB, patch)
2014-01-14 05:55 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Merllissia Manueli 2014-01-13 22:51:37 UTC

    
Comment 1 AlexHorsman 2014-01-13 22:59:15 UTC Comment hidden (obsolete)
Comment 2 Liz Rea 2014-01-13 23:02:43 UTC Comment hidden (obsolete)
Comment 3 Liz Rea 2014-01-13 23:04:41 UTC
Comment on attachment 24244 [details] [review]
bug 11537: Increasing test coverage for C4::Log

Removing, as signoff has to be outside catalyst.
Comment 4 David Cook 2014-01-13 23:12:33 UTC Comment hidden (obsolete)
Comment 5 Chris Cormack 2014-01-13 23:16:26 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2014-01-14 05:55:15 UTC
Created attachment 24268 [details] [review]
[PASSED QA] Bug 11537: Increasing test coverage for C4::Log

To test:
1. run prove t/Log.t
   Notice 1 test is run
2. apply patch
3. run prove t/Log.t
   Notice 3 tests are run

Signed-off-by: David Cook <dcook@prosentient.com.au>

Works as described.

I think there might be a typo in "Testing git log status". Should
this read "Testing get log status"? (Noticed while looking at the
code/running perl t/Log.t.)

In any case, thanks for the patch. Looks good!

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Fixed typo, thanks David

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described:
1..3
ok 1 - use C4::Log;
ok 2 - Testing GetLogStatus
ok 3 - Testing hash is non empty
Comment 7 Katrin Fischer 2014-01-14 05:56:08 UTC
Welcome Alex!
Comment 8 Galen Charlton 2014-01-14 16:35:53 UTC
Pushed to master. Congratulations on having your first patch accepted into Koha, Alex!
Comment 9 Galen Charlton 2014-01-14 19:30:35 UTC
Upon Jenkins (the continuous integration service) complaining, I've also pushed a follow-up that mocks the calls to C4::Context::preference() that C4::Log::GetLogStatus() makes, which will allow the test to pass without requiring that a Koha database is present and pointed to by a valid Koha configuration.